Skip to content

Add support for gathering, publishing and fetching metrics#12

Merged
porridge merged 3 commits intomasterfrom
metrics
Jun 4, 2024
Merged

Add support for gathering, publishing and fetching metrics#12
porridge merged 3 commits intomasterfrom
metrics

Conversation

@porridge
Copy link
Copy Markdown
Collaborator

@porridge porridge commented May 9, 2024 •
edited
Loading

Tested in stackrox/stackrox#11018.

Depends on the following which need to be merged first:

@porridge porridge requested a review from janisz May 9, 2024 10:11
@porridge porridge mentioned this pull request May 9, 2024
Merged
11 tasks
janisz
janisz reviewed May 14, 2024
View reviewed changes
Comment thread .github/workflows/build.yaml Outdated
@porridge porridge changed the base branch from master to kubeconform May 22, 2024 09:57
@porridge porridge requested a review from janisz May 22, 2024 10:16
Base automatically changed from kubeconform to master May 22, 2024 16:47
janisz
janisz previously requested changes May 23, 2024
View reviewed changes
Copy link
Copy Markdown

@janisz janisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I miss tests for this :(

Comment thread internal/main.go
Comment thread internal/metrics/submitter/main.go Outdated
Comment thread internal/metrics/submitter/main.go Outdated
Comment thread internal/metrics/submitter/main.go Outdated
Comment thread internal/metrics/submitter/main.go Outdated
Comment thread internal/metrics/submitter/main.go Outdated
Comment thread internal/metrics/submitter/main.go Outdated
Comment thread internal/metrics/submitter/main.go Outdated
Comment thread internal/metrics/server/main.go Outdated
Comment thread internal/metrics/server/main.go Outdated
@porridge porridge mentioned this pull request May 23, 2024
Merged
@porridge
Copy link
Copy Markdown
Collaborator Author

porridge commented May 27, 2024

Comments addressed, and #18 adds an e2e test on top. PTAL

@janisz janisz dismissed their stale review May 27, 2024 19:15

I'm on PTO so I'd not block it

janisz
janisz approved these changes Jun 3, 2024
View reviewed changes
Comment thread README.md
@porridge porridge merged commit 0beaf8d into master Jun 4, 2024
@porridge porridge deleted the metrics branch June 4, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janisz janisz janisz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@porridge @janisz