Conversation
Collaborator
porridge
commented
May 22, 2024
porridge
commented
- change deploy tool to use the flag package where appropriate rather than positional arguments for everything, as they would become a mess when another is added,
- rename daemonSetTemplate to deploymentTemplate as it already contains more than the daemonset, and will continue to grow soon,
- rename some variables to mention CRI to make room for an upcoming non-cri client/connection,
- extract a logging package, to be used in upcoming subcommand,
- in README and GHA workflow, correct deploy tool usage
- in README, mention daemonset in individual commands,
- use consistent indentation in the deployment template
- build the deploy tool just once in GH action
- change deploy tool to use the flag package where appropriate rather than positional arguments for everything, as they would become a mess when another is added, - rename daemonSetTemplate to deploymentTemplate as it already contains more than the daemonset, and will continue to grow soon, - rename some variables to mention CRI to make room for an upcoming non-cri client/connection, - extract a logging package, to be used in upcoming subcommand, - in README and GHA workflow, correct deploy tool usage - in README, mention daemonset in individual commands, - use consistent indentation in the deployment template - build the deploy tool just once in GH action
2 tasks
janisz
approved these changes
May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.