Total count and configurable default per_page#31
Merged
stas merged 5 commits intostas:masterfrom Dec 12, 2020
Merged
Conversation
Owner
|
@jkorz there's already a PR related to the totals (stalled, for which I'm ashamed 🙈), please take a look at #29 I like the idea of moving away from the constant, so I'd be happy to merge that part. But if I may suggest, I'd like us to keep the naming similar to what we have now, as in: To move forward with this, I suggest we merge #29 and let you rebase your work to cover just the default page size setup. How does that sound to you? |
Contributor
Author
|
@stas sounds good to me |
Contributor
Author
|
@stas I made the changes you requested. |
stas
reviewed
Dec 7, 2020
Owner
|
@jkorz this is good to go, let's just make sure the CI passes. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Default per-page is 30 and set using a constant. Pagination meta does not include total number of records.
What is the new behavior?
Implementers may now configure the default per-page by defining a method. Total number of records is included in the pagination meta.
Checklist
Please make sure the following requirements are complete:
features)