Skip to content

Describe JSONAPI_PAGE_SIZE constant#36

Closed
xhs345 wants to merge 1 commit intostas:masterfrom
xhs345:patch-1
Closed

Describe JSONAPI_PAGE_SIZE constant#36
xhs345 wants to merge 1 commit intostas:masterfrom
xhs345:patch-1

Conversation

@xhs345
Copy link
Contributor

@xhs345 xhs345 commented Jan 27, 2021

Explain how to return page with more than 30 items when using pagination (see #24).

What is the current behavior?

Description is missing

What is the new behavior?

Description is added

Checklist

Please make sure the following requirements are complete:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes /
    features)
  • All automated checks pass (CI/CD)

Explain how to return page with more than 30 items when using pagination (see stas#24).
@stas
Copy link
Owner

stas commented Jan 28, 2021

@xhs345 thank you for the PR.

I actually merged #31 for this reason and I'm planning to deprecate JSONAPI_PAGE_SIZE, just not in the nearest version.

So the answer is to just use jsonapi_page_size for now. Let me know if this helps!

@xhs345
Copy link
Contributor Author

xhs345 commented Jan 28, 2021

Ok, makes sense! Thanks

@xhs345 xhs345 closed this Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants