feat: add math/base/special/atan2f

[Neerajpathak07]

Progresses #649

Description

What is the purpose of this pull request?

This pull request:

• proposes adding math/base/special/atan2f , which would be a single precision implementation for math/base/special/atan2.

Related Issues

Does this pull request have any related issues?

This pull request:

• progresses [RFC]: Add C implementations to base special math functions (tracking issue) #649

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines

---

@stdlib-js/reviewers

[aayush0325]

i see that this PR is failing a lot of tests. you should update your manifest.json to include all the necessary single-precsion dependencies to use them in src/ and lib/ currently you are including double precision dependencies but using the single-precision ones which is why this is causing an error.

[aayush0325]

"dependencies": [
        "@stdlib/math/base/napi/binary",
        "@stdlib/math/base/assert/is-infinitef",
        "@stdlib/math/base/special/copysignf",
        "@stdlib/number/float32/base/signbit",
        "@stdlib/math/base/assert/is-nanf",
        "@stdlib/math/base/special/atanf",
        "@stdlib/constants/float32/pinf",
        "@stdlib/constants/float32/pi"
      ]

this is how you should fill the dependencies in manifest.json

[Neerajpathak07]

@aayush0325 thanks for the assist.

[aayush0325]

use number/float32/base/signbit instead of number/float32/base/signbitf as the latter doesn't exist, checkout the package here

[Planeshifter]

@Neerajpathak07 The issue here is that @stdlib/number/float32/base/signbit doesn't yet have a C implementation. This PR will have to wait until we have that C implementation.

[Neerajpathak07]

@Planeshifter The PR related to float32/signbit has been merged could you unblock this PR

[aayush0325]

basically you need to generate the fixtures using the julia script and not copy them over from the double precision implementation

[aayush0325]

The reason for the failing benchmarks is probably because you copied over the Makefile wrongly, use the one in math/base/special/atan2/benchmark/c/native/

[aayush0325]

Makefile that you should be using. This adds the include dirs so that you don't run into the error that we're currently facing here

[Neerajpathak07]

Julia doesn't have support for computing atan2f and atan2 so have kept it atan cuz that's the only one we have. But have generated it for float32

[Neerajpathak07]

@aayush0325 Well the error still persists even after generating fixtures for julia.

[Neerajpathak07]

@Planeshifter Only two test cases are failing in test.native.js whilst every tests and running-clean in test.js. Is there something I am missing out??

[anandkaranubc]

Completed via #7081

[stdlib-bot]

Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit.

Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions.