feat: add C implementation for number/float32/base/signbit#3399
Conversation
|
Check out the workflow failures. E.g., the lint step of tells us that several needed fields are not set and should be added. |
|
@Planeshifter I have added the essential files in the dependency tree of package.json. |
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
@Planeshifter All CI checks are passing pls review it. I am going to need this for implementing |
|
@Neerajpathak07 Wil try taking a look and review tonight. |
Planeshifter
left a comment
There was a problem hiding this comment.
Thanks for your work on this!
Looks pretty good to me. manifest.json will need some updates. @kgryte, you mind taking final look please and then merge the PR after the comments have been addressed?
|
@Planeshifter Thank you for the review. |
|
/stdlib update-copyright-years |
|
/stdlib merge |
kgryte
left a comment
There was a problem hiding this comment.
After a bit of clean-up, this PR now LGTM.
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: na
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
- task: run_javascript_examples
status: na
- task: run_c_examples
status: na
- task: run_cpp_examples
status: na
- task: run_javascript_readme_examples
status: na
- task: run_c_benchmarks
status: na
- task: run_cpp_benchmarks
status: na
- task: run_fortran_benchmarks
status: na
- task: run_javascript_benchmarks
status: na
- task: run_julia_benchmarks
status: na
- task: run_python_benchmarks
status: na
- task: run_r_benchmarks
status: na
- task: run_javascript_tests
status: na
---
PR-URL: stdlib-js#3399 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> Co-authored-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com>
PR-URL: stdlib-js#3399 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> Co-authored-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com>
PR-URL: stdlib-js#3399 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> Co-authored-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com>
PR-URL: stdlib-js#3399 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> Co-authored-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com>
Resolves #3397
Description
This pull request:
number/float32/base/signbitRelated Issues
This pull request:
number/float32/base/signbit#3397 & [RFC]: Add C implementations to base special math functions (tracking issue) #649Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers