feat: add C implementation for `stats/base/dists/signrank/quantile` by jalajk3004 · Pull Request #4734 · stdlib-js/stdlib

jalajk3004 · 2025-01-13T17:06:39Z

Resolves

#3885

Description

What is the purpose of this pull request?

This pull request:

Adds a C implementation of the Quantile for a signrank distribution.
Includes benchmarks for the C implementation.
Provides examples demonstrating the usage of the Quantile for a Signrank distribution in C.

Related Issues

Does this pull request have any related issues?

This pull request:

resolving feat: add C implementation for stats/base/dists/studentized-range/cdf #4154

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: failed ---

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: failed ---

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: failed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: failed ---

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: failed ---

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: failed ---

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: failed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: failed ---

stdlib-bot · 2025-01-13T17:07:15Z

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

Please read our contributing guidelines.
Update your pull request description to include this checked box:

- [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

The developer's certificate of origin
Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

PR-URL: stdlib-js#4728 Reviewed-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

PR-URL: stdlib-js#4729 Reviewed-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

…apxsumkbn` PR-URL: stdlib-js#4732 Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

PR-URL: stdlib-js#4713 Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

…base/dmeankbn2` PR-URL: stdlib-js#4715 Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

…ntions PR-URL: stdlib-js#4737 Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

PR-URL: stdlib-js#4739 Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

PR-URL: stdlib-js#4093 Closes: stdlib-js#3641 Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

PR-URL: stdlib-js#4741 Reviewed-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

PR-URL: stdlib-js#4742 Reviewed-by: Athan Reines <kgryte@gmail.com>

PR-URL: stdlib-js#4740 Reviewed-by: Athan Reines <kgryte@gmail.com>

PR-URL: stdlib-js#4744 Reviewed-by: Athan Reines <kgryte@gmail.com>

PR-URL: stdlib-js#3399 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> Co-authored-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com>

PR-URL: stdlib-js#4746 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com>

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: passed - task: run_c_examples status: failed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: passed - task: run_c_examples status: failed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: passed - task: run_c_examples status: failed ---

jalajk3004 · 2025-01-14T18:12:41Z

@anandkaranubc I hope this message finds you well. I kindly request your review of my PR #4734. If you find any issues or areas for improvement, please let me know. I am more than happy to make the necessary changes. I really want my PR to get merged

Thank you for your time and guidance!

anandkaranubc · 2025-01-15T11:06:49Z

Hi @jalajk3004, it seems your PR includes unrelated changes from the stdlib repo, likely introduced when you updated your branch with new changes from develop. To fix this, rebase your branch onto the latest develop to exclude unrelated changes and confirm that only relevant files are included in the PR. After rebasing, review the changes and push (might have to force-push) the updated branch to clean up the PR.

Let me know when you are done with this and I will revisit the PR again :)

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: ---

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

jalajk3004 · 2025-01-15T12:37:20Z

@anandkaranubc I have followed your instruction, Rebase my branch quantile onto the latest develop branch to exclude unrelated changes and confirm that only relevant files are included in the PR. and did the force-push.
But still there are errors. Kindly look into it and guide me

yaswanthkosuru · 2025-02-09T14:07:40Z

@jalajk3004 Before Making PR please ensure your files changes .
Here it was showing 150 files changed it seems like lot of changes which leads doesnt merge these P.R. You can Close These and open new one with consisting of only files under these folder Or you can Modify these one to only include file changes to ~20. Correct me if i am wrong

anandkaranubc · 2025-02-09T15:47:54Z

Or you can update your current branch by using the GitHub UI only. Just go to your forked repo, select your branch, sync it and then pull the changes locally.

jalajk3004 added 10 commits January 13, 2025 06:27

feat:add c implementation example file

10daf8c

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: failed ---

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 13, 2025

stdlib-bot and others added 16 commits January 14, 2025 18:07

docs: update related packages sections

66cb237

PR-URL: stdlib-js#4728 Reviewed-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

docs: update namespace TypeScript declaration comments

b157d1c

PR-URL: stdlib-js#4729 Reviewed-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

fix: add math/base/speical/abs in manifest.json of `blas/ext/base/d…

9ccf049

…apxsumkbn` PR-URL: stdlib-js#4732 Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

docs: update examples of stats/base/dmin

fefd435

PR-URL: stdlib-js#4713 Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

feat: add C ndarray interface and refactor implementation for `stats/…

4dec3dd

…base/dmeankbn2` PR-URL: stdlib-js#4715 Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

refactor: update blas/ext/base/dapx to follow current project conve…

f742e64

…ntions PR-URL: stdlib-js#4737 Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

docs: update related packages sections

93ba64e

PR-URL: stdlib-js#4739 Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

docs: update REPL namespace documentation

14c1188

PR-URL: stdlib-js#4741 Reviewed-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

docs: update namespace table of contents

774fae5

PR-URL: stdlib-js#4742 Reviewed-by: Athan Reines <kgryte@gmail.com>

docs: update namespace TypeScript declarations

cc0e85c

PR-URL: stdlib-js#4740 Reviewed-by: Athan Reines <kgryte@gmail.com>

bench: refactor random number generation in stats/base/dists/arcsine

d4fa726

PR-URL: stdlib-js#4744 Reviewed-by: Athan Reines <kgryte@gmail.com>

feat: add C ndarray API and refactor blas/ext/base/sapxsumors

8c49027

PR-URL: stdlib-js#4746 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com>

jalajk3004 mentioned this pull request Jan 14, 2025

[RFC]: Add C implementation for @stdlib/stats/base/dists/signrank/quantile #3885

Open

3 tasks

jalajk3004 added 2 commits January 15, 2025 12:08

jalajk3004 force-pushed the quantile branch from f44e0b1 to 29fa8b9 Compare January 15, 2025 12:25

jalajk3004 mentioned this pull request Mar 29, 2025

[RFC]: Developer dashboard for tracking ecosystem build failures stdlib-js/google-summer-of-code#120

Closed

7 tasks

Planeshifter changed the title ~~feat: add C implementation for @stdlib/stats/base/dists/signrank/quantile~~ feat: add C implementation for stats/base/dists/signrank/quantile Jan 14, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add C implementation for `stats/base/dists/signrank/quantile`#4734

feat: add C implementation for `stats/base/dists/signrank/quantile`#4734
jalajk3004 wants to merge 28 commits into
stdlib-js:developfrom
jalajk3004:quantile

jalajk3004 commented Jan 13, 2025 •

edited

Loading

Uh oh!

stdlib-bot commented Jan 13, 2025

Uh oh!

jalajk3004 commented Jan 14, 2025

Uh oh!

anandkaranubc commented Jan 15, 2025 •

edited

Loading

Uh oh!

jalajk3004 commented Jan 15, 2025 •

edited

Loading

Uh oh!

yaswanthkosuru commented Feb 9, 2025 •

edited

Loading

Uh oh!

anandkaranubc commented Feb 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

jalajk3004 commented Jan 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Resolves

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Jan 13, 2025

Uh oh!

jalajk3004 commented Jan 14, 2025

Uh oh!

anandkaranubc commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jalajk3004 commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yaswanthkosuru commented Feb 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anandkaranubc commented Feb 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

jalajk3004 commented Jan 13, 2025 •

edited

Loading

anandkaranubc commented Jan 15, 2025 •

edited

Loading

jalajk3004 commented Jan 15, 2025 •

edited

Loading

yaswanthkosuru commented Feb 9, 2025 •

edited

Loading