bench: refactor random number generation in stats/base/dists/uniform

[MunishMummadi]

This issue is related to #4991 i.e RFC:

Description

This PR has changes to benchmarking file located at stats/base/dists/uniform

This pull request:

• Replaced rand() with corresponding uniform() implementation within the benchmarking files.

Questions

No

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines.

---

@stdlib-js/reviewers

[stdlib-bot]

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

[stdlib-bot]

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/uniform/cdf	$\color{green}225/225$ $\color{green}+100.00\%$	$\color{green}25/25$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}225/225$ $\color{green}+100.00\%$
stats/base/dists/uniform/ctor	$\color{green}479/479$ $\color{green}+100.00\%$	$\color{green}43/43$ $\color{green}+100.00\%$	$\color{green}18/18$ $\color{green}+100.00\%$	$\color{green}479/479$ $\color{green}+100.00\%$
stats/base/dists/uniform/entropy	$\color{green}184/184$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}184/184$ $\color{green}+100.00\%$
stats/base/dists/uniform/kurtosis	$\color{green}119/119$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}119/119$ $\color{green}+100.00\%$
stats/base/dists/uniform/logcdf	$\color{green}229/229$ $\color{green}+100.00\%$	$\color{green}25/25$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}229/229$ $\color{green}+100.00\%$
stats/base/dists/uniform/logpdf	$\color{green}219/219$ $\color{green}+100.00\%$	$\color{green}23/23$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}219/219$ $\color{green}+100.00\%$
stats/base/dists/uniform/mean	$\color{green}175/175$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}175/175$ $\color{green}+100.00\%$
stats/base/dists/uniform/median	$\color{green}175/175$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}175/175$ $\color{green}+100.00\%$
stats/base/dists/uniform/mgf	$\color{green}235/235$ $\color{green}+100.00\%$	$\color{green}21/21$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}235/235$ $\color{green}+100.00\%$
stats/base/dists/uniform/pdf	$\color{green}287/287$ $\color{green}+100.00\%$	$\color{green}25/25$ $\color{green}+100.00\%$	$\color{green}4/4$ $\color{green}+100.00\%$	$\color{green}287/287$ $\color{green}+100.00\%$
stats/base/dists/uniform/quantile	$\color{green}215/215$ $\color{green}+100.00\%$	$\color{green}22/22$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}215/215$ $\color{green}+100.00\%$
stats/base/dists/uniform/skewness	$\color{green}119/119$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}119/119$ $\color{green}+100.00\%$
stats/base/dists/uniform/stdev	$\color{green}122/122$ $\color{green}+100.00\%$	$\color{green}5/5$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}122/122$ $\color{green}+100.00\%$
stats/base/dists/uniform/variance	$\color{green}182/182$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}182/182$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

[anandkaranubc]

Thanks, @MunishMummadi, for working on this! I've left a few suggestions for you to review.

Also, can you change the title to:

bench: refactor random number generation in stats/base/dists/uniform

[MunishMummadi]

Sure, I have updated the title.

[MunishMummadi]

@anandkaranubc I don't see any code review. If that's what you mean by suggestions. Please correct me if I am wrong.

[anandkaranubc]

The random number generation should be moved outside the benchmarking loop, before b.tic().

[MunishMummadi]

The random number generation should be moved outside the benchmarking loop, before b.tic().

I have a question about this suggestion. Are you expecting this change only for this file or to the complete PR.

[anandkaranubc]

Yes, this change is expected in the complete PR. One of the main reasons for this refactoring is to ensure that random number generation does not interfere with benchmarking. Reference PRs would be a good source to verify if your changes are correct.

[MunishMummadi]

Thanks for the confirmation. I thought so, I will update soon.

[anandkaranubc]

@anandkaranubc I don't see any code review. If that's what you mean by suggestions. Please correct me if I am wrong.

Sorry, my bad. They should be visible now.

[MunishMummadi]

@anandkaranubc I also added changes where they seem fit. i have doubts about the b.tic() i commented about it on the code review.
edit: changed to changes

[anandkaranubc]

Suggested change

	x = uniform( -10.0, 10.0 );
	min = uniform( -20.0, 0.0 );
	max = uniform( min, min + 40.0 );
	len = 100;
	x = new Float64Array( len );
	min = new Float64Array( len );
	max = new Float64Array( len );
	for ( i = 0; i < len; i++ ) {
	x[ i ] = uniform( -10.0, 10.0 );
	min[ i ] = uniform( -20.0, 0.0 );
	max[ i ] = uniform( min[ i ], min[ i ] + 40.0 );
	}

This would be the correct way to initialize random values for the variables.

[MunishMummadi]

Thanks for this update. This really helps!!!

[Planeshifter]

Meanwhile #5176 was merged, so this PR won't be needed anymore. Thanks for your efforts, @MunishMummadi, which we appreciate!