bench: refactor random number generation in JS benchmarks for stats/base/dists/uniform#5176
Conversation
stdlib-bot
left a comment
There was a problem hiding this comment.
👋 Hi there! 👋
And thank you for opening your first pull request! We will review it shortly. 🏃 💨
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
Thanks @G4URAV001 for working on this. Left a few comments for you to review. Good luck! |
Thanks @anandkaranubc for the comments. Did all the correction and ran the following tests locally in a dev container - [x] Build Native Add-on. Still if anything is missed I can do the changes Sorry for the silly things I missed earlier, I should have been more observant. Looking forward for more contributions |
|
/stdlib lint-autofix |
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
|
/stdlib lint-autofix |
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: na
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
- task: run_javascript_examples
status: na
- task: run_c_examples
status: na
- task: run_cpp_examples
status: na
- task: run_javascript_readme_examples
status: na
- task: run_c_benchmarks
status: na
- task: run_cpp_benchmarks
status: na
- task: run_fortran_benchmarks
status: na
- task: run_javascript_benchmarks
status: na
- task: run_julia_benchmarks
status: na
- task: run_python_benchmarks
status: na
- task: run_r_benchmarks
status: na
- task: run_javascript_tests
status: na
---
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: na
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
- task: run_javascript_examples
status: na
- task: run_c_examples
status: na
- task: run_cpp_examples
status: na
- task: run_javascript_readme_examples
status: na
- task: run_c_benchmarks
status: na
- task: run_cpp_benchmarks
status: na
- task: run_fortran_benchmarks
status: na
- task: run_javascript_benchmarks
status: na
- task: run_julia_benchmarks
status: na
- task: run_python_benchmarks
status: na
- task: run_r_benchmarks
status: na
- task: run_javascript_tests
status: na
---
Planeshifter
left a comment
There was a problem hiding this comment.
Thanks for your first PR, which I will go ahead and merge shortly.
Going forward, please make sure you have your local development environment setup correctly, including EditorConfig and ESLint. The PR had a bunch of lint errors that would have been caught by our GIt hooks if properly initialized.
stats/base/dists/uniform
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
…e/dists/uniform` PR-URL: stdlib-js#5176 Closes: stdlib-js#4991 Ref: stdlib-js#4837 Ref: stdlib-js#4955 Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Co-authored-by: stdlib-bot <noreply@stdlib.io> Reviewed-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
…ts/uniform
#4991
Resolves #4991 .
Description
This pull request improves random number generation in JS benchmarks for
stats/base/dists/uniform. Specifically:@stdlib/random/base/uniformand@stdlib/random/base/discrete-uniforminstead ofranduexpressions.Related Issues
stats/base/dists/uniform#4991stats/base/dists/beta#4837 and bench: refactor random number generation instats/base/dists/hypergeometric#4955 as examples of similar improvements.Questions
No.
Other
No.
Checklist
✅ Read, understood, and followed the contributing guidelines.
✅ Build Native Add-on.
✅ Run JavaScript Benchmarks.
✅ Run JavaScript Native Benchmarks.
@stdlib-js/reviewers