Enable smart contract addresses in contacts store

[ElliotFriend]

Right now, we're checking that an entered contact has a valid G... address. We should update this add function so it can check for and allow contacts with smart contract C... addresses.

[ShantelPeters]

Hi @ElliotFriend please i will like to work on this issue when the OD hack begins

[onlydustapp]

Hi @ShantelPeters!
Maintainers during the ODHack # 8.0 will be tracking applications via OnlyDust.
Therefore, in order for you to have a chance at being assigned to this issue, please apply directly here, or else your application may not be considered.

[MPSxDev]

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hello, I am Manuel, a process engineer and web3 developer. I have participated in Starknet Bootcamps, ETHGlobal and am an Elite winner of Speedrunstark. I have a high capacity to solve problems. I am a member of the DojoCoding community.
I hope this issue is assigned to me. I am available to work immediately to achieve what is required in the shortest time possible.

How I plan on tackling this issue

To address the requirements of the issue, I will:

1. Update the add function in the contacts store to accept and validate smart contract addresses that start with "C...".
2. Modify the existing validation logic to check for both standard G... addresses and the new C... addresses.
3. Ensure that the input format for smart contract addresses adheres to any relevant standards or patterns.
4. Test the updated add function to verify that it correctly accepts valid smart contract addresses and rejects invalid ones.

[ooochoche]

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I am a SC developer

How I plan on tackling this issue

I can work on this

[aji70]

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

i'm a solidity and cairo smart contract developer with over 2 years experience and believe i have the skill set for the task and i am also very good with smart contract testing

[SoarinSkySagar]

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

GM, I am Sagar Rana, a smart contract developer and full stack engineer. I have 3 years of experience building robust full stack applications and over a year of writing smart contracts. You can see my projects and contributions to some major repos on my GitHub profile. The tech stack I use mainly includes Solidity, Rust, JavaScript and Typescript. I am also contributing to the Starknet and Rust ecosystems and building on Cairo and Rust languages. I am interested in contributing to projects like this to learn more about these technologies and help make these projects better. Please assign me as I would be really glad to be a contributor in this project! :)

How I plan on tackling this issue

Hi @ElliotFriend, I would approach this issue like this:

• We can add an extra check in the add function to check for both valid Ed25519 public keys and Smart Contract addresses. Here's the relevant code for the C...address checking:

const isValidContractAddress = StrKey.isValidContract(contact.address);

• The if condition has to be changed now to be isValidEd25519PublicKey || isValidContractAddress so that either of the two being true will successfully execute the function.

Tasks:

• Implement the C... contract checking logic

ETA: 5 Hours

[ShantelPeters]

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

hello i am Shantel, a blockchain developer .and technical writer ,i have a high capacity to tackle issues. i hope this issue is assigned to me , i am avalaible to work

How I plan on tackling this issue

i will approach the problem with the following:

1. Update Validation Logic: Modify the existing validation function for contact addresses to include checks for both G... and C... addresses.
2. Identify Address Types: Ensure the function can differentiate between a regular G... address and a smart contract C... address, validating the format appropriately.
3. Adjust Add Function: Update the add function to allow the entry of C... addresses, ensuring it calls the modified validation logic.
4. Test Functionality: Test the updated function to ensure it correctly accepts both types of addresses without errors.

[ScottyDavies]

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I am a blockchain developer with experience in smart contract integration,

How I plan on tackling this issue

To tackle the issue, I would:

Examine the existing address validation logic for G... addresses.

Determine the criteria for validating C... addresses, ensuring they conform to the expected format.

Modify the add function to include a check for both G... and C... addresses, allowing valid C... addresses to be accepted.

Implement tests to ensure both types of addresses are validated correctly without breaking existing functionality.

Update any relevant documentation to reflect the changes in address validation.

[SoarinSkySagar]

Hi @ElliotFriend, created PR #31 to close this issue; please review