Skip to content

Conversation

@SoarinSkySagar
Copy link
Contributor

Closes #19

Checklist

  • Implemented C... smart contract checking logic
  • Ensured everything works correctly by running yarn build

Hi @ElliotFriend, please review and merge this PR under ODHack 8.0!

@SoarinSkySagar
Copy link
Contributor Author

SoarinSkySagar commented Oct 7, 2024

@ElliotFriend please review the PR for any changes required, closes issue #19

Copy link
Contributor

@ElliotFriend ElliotFriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there @SoarinSkySagar!! Thanks for taking on this task!

There have been some updates to packages (#23), which has resulted in some conflicts in your PR. If you get those conflicts resolved, you won't need the import in package.json, and you can leave the StrKey import alone, as it'll be coming from the updated @stellar/stellar-sdk package.

I think your change on line 52 is exactly what we need, though! As soon as you get the new changes merged in and remove the other two changes, I can get this merged right awya.

Thanks!

@SoarinSkySagar
Copy link
Contributor Author

I think your change on line 52 is exactly what we need, though! As soon as you get the new changes merged in and remove the other two changes, I can get this merged right awya.

@ElliotFriend, conflict resolved!

@SoarinSkySagar
Copy link
Contributor Author

@ElliotFriend can you please review it again? been more than a day since i merged the conflicts

Copy link
Contributor

@ElliotFriend ElliotFriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for the contribution!

@ElliotFriend ElliotFriend merged commit f115d48 into stellar:main Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable smart contract addresses in contacts store

2 participants