Skip to content

(Closes #2612) add support for length attribute in character type#3377

Open
arporter wants to merge 21 commits intomasterfrom
2612_add_len_to_scalartype
Open

(Closes #2612) add support for length attribute in character type#3377
arporter wants to merge 21 commits intomasterfrom
2612_add_len_to_scalartype

Conversation

@arporter
Copy link
Member

No description provided.

@arporter arporter marked this pull request as draft March 16, 2026 19:37
@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.95%. Comparing base (c54c5f1) to head (c1bbb7f).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #3377    +/-   ##
========================================
  Coverage   99.95%   99.95%            
========================================
  Files         387      388     +1     
  Lines       54315    54478   +163     
========================================
+ Hits        54293    54456   +163     
  Misses         22       22            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arporter
Copy link
Member Author

This is a little bigger than I'd have liked because, in quite a few tests, we use character as a "type that we don't support". I've kicked this can down the road a bit by switching to complex but we will also want to add support for that soon. Perhaps at that point there will be no basic type that we don't support?

@arporter arporter added enhancement PSyIR Core PSyIR functionality labels Mar 23, 2026
@arporter arporter marked this pull request as ready for review March 23, 2026 17:08
@arporter
Copy link
Member Author

Something goes very wrong in the NEMO ITs:
image
I don't have a test with len=some_intrinsic(arg)...

@arporter arporter deployed to integration March 23, 2026 21:24 — with GitHub Actions Active
@arporter
Copy link
Member Author

NEMO ITs now failing at L274 of acc_kernels_trans.py with:

    if isinstance(sym.datatype.length,
406
                  ^^^^^^^^^^^^^^^^^^^
407
AttributeError: 'UnsupportedFortranType' object has no attribute 'length'
408

when processing crslbclnk.f90.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement in progress PSyIR Core PSyIR functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant