Skip to content

Conversation

@tpiperatgod
Copy link
Contributor

Signed-off-by: laminar tpiperatgod@gmail.com

@tpiperatgod tpiperatgod requested review from a team and tuteng as code owners June 21, 2022 03:27
@netlify
Copy link

netlify bot commented Jun 21, 2022

Deploy Preview for function-mesh ready!

Name Link
🔨 Latest commit 29fa7b5
🔍 Latest deploy log https://app.netlify.com/sites/function-mesh/deploys/62ba69716bf36600091cf4cd
😎 Deploy Preview https://deploy-preview-134--function-mesh.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tpiperatgod tpiperatgod force-pushed the helm_chart_with_webhook branch 3 times, most recently from f130cc2 to c6ed6aa Compare June 21, 2022 03:38
Copy link
Contributor

@Huanli-Meng Huanli-Meng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave my comments, PTAL

@tpiperatgod tpiperatgod force-pushed the helm_chart_with_webhook branch from c6ed6aa to 0f07971 Compare June 22, 2022 01:11
@tpiperatgod
Copy link
Contributor Author

Leave my comments, PTAL

done

@Huanli-Meng Huanli-Meng changed the title add docs for setting up webhook [Do not merge][FM v0.3.0]add docs for setting up webhook Jun 22, 2022
@tpiperatgod tpiperatgod force-pushed the helm_chart_with_webhook branch from 0f07971 to 05d7012 Compare June 22, 2022 10:00
@Huanli-Meng Huanli-Meng changed the title [Do not merge][FM v0.3.0]add docs for setting up webhook [FM v0.3.0]add docs for setting up webhook Jun 28, 2022
@tpiperatgod tpiperatgod force-pushed the helm_chart_with_webhook branch from ddbffd5 to 29fa7b5 Compare June 28, 2022 02:37
@tpiperatgod
Copy link
Contributor Author

@Huanli-Meng @freeznet needs your double-check, please help to review it, thanks!

Copy link
Contributor

@Huanli-Meng Huanli-Meng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Huanli-Meng Huanli-Meng merged commit 7d70afe into streamnative:main Jun 29, 2022
@tpiperatgod tpiperatgod deleted the helm_chart_with_webhook branch July 13, 2022 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants