Add webhook to chart #381
Add webhook to chart #381
Conversation
There was a problem hiding this comment.
lgtm, but left some comments as questions, ptal, thanks.
also, could you please check if the changes affect function-mesh worker service https://github.com/streamnative/function-mesh-worker-service/blob/master/.ci/helm.sh#L118-L136, thanks.
This PR does not change the usage when using cert-manager to manage webhook certificates. I checked the ci workflows for the function-mesh and function-mesh-worker-service repositories and they both manage certificates through the cert-manager, so this PR does not affect either workflow. |
thanks @tpiperatgod, is it possible to enable webhook to the ci workflows after this PR merged? |
Yes, it will be enabled by default. But the current ci workflow |
Signed-off-by: laminar <tpiperatgod@gmail.com>
add the "go-get-tool" function to get the go library. Signed-off-by: laminar <tpiperatgod@gmail.com>
- add a subchart named "admission-webhook" - move CRDs to the "templates" dir - remove the "crds" dir - we currently use Cert Manager to manage certificates when communicating with the webhook Signed-off-by: laminar <tpiperatgod@gmail.com>
- use "function-mesh-admission-webhook-service" as the name of the webhook service - change the template name from "function-mesh-operator.service.webhook" to "function-mesh-operator.webhook.service" - change the template name from "function-mesh-operator.certificate.secretName" to "function-mesh-operator.certificate.secret" Signed-off-by: laminar <tpiperatgod@gmail.com>
- add the "function-mesh-secrets-webhook" chart, which contains two Secret resources: - CA Secret ( automatically generated by the Helm functions ) - certificate Secret ( automatically generated by the Helm functions ) Signed-off-by: laminar <tpiperatgod@gmail.com>
add `custom` certificates provider Signed-off-by: laminar <tpiperatgod@gmail.com>
Signed-off-by: laminar <tpiperatgod@gmail.com>
use the fixed name `function-mesh-admission-webhook-server-cert` as the of Certificate and Secret Signed-off-by: laminar <tpiperatgod@gmail.com>
|
The doc is added through this PR: streamnative/function-mesh-website#134 |
4 participants
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #319
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>to link to the master issue.)Master Issue: #
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required[FM v0.3.0]add docs for setting up webhook function-mesh-website#134
(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)