This repository was archived by the owner on Jan 24, 2024. It is now read-only.
[FEATURE] Add metric about the time spent on message conversions#1016
Merged
BewareMyPower merged 6 commits intostreamnative:masterfrom Jan 18, 2022
Merged
[FEATURE] Add metric about the time spent on message conversions#1016BewareMyPower merged 6 commits intostreamnative:masterfrom
BewareMyPower merged 6 commits intostreamnative:masterfrom
Conversation
Contributor
Author
|
@Demogorgon314 @BewareMyPower PTAL, thanks. |
Collaborator
BewareMyPower
left a comment
BewareMyPower
left a comment
There was a problem hiding this comment.
Could you update tests in MetricsProviderTest?
BewareMyPower
added
the
type/enhancement
Contributor
Author
Addressed done, PTAL Thanks. |
Demogorgon314
approved these changes
Jan 18, 2022
BewareMyPower
approved these changes
Jan 18, 2022
BewareMyPower
pushed a commit
that referenced
this pull request
Jan 23, 2022
Add related docs for #1016
BewareMyPower
pushed a commit
that referenced
this pull request
Jan 23, 2022
In PR #845, we added the conversion metrics of the number of messages, and the metrics of message conversion time is still very useful.
BewareMyPower
pushed a commit
that referenced
this pull request
Jan 23, 2022
Add related docs for #1016
BewareMyPower
pushed a commit
that referenced
this pull request
Jan 23, 2022
In PR #845, we added the conversion metrics of the number of messages, and the metrics of message conversion time is still very useful.
BewareMyPower
pushed a commit
that referenced
this pull request
Jan 23, 2022
Add related docs for #1016
BewareMyPower
pushed a commit
that referenced
this pull request
Feb 9, 2022
BewareMyPower
pushed a commit
that referenced
this pull request
Feb 9, 2022
eolivelli
pushed a commit
to eolivelli/kop
that referenced
this pull request
Feb 24, 2022
…eamnative#1016) In PR streamnative#845, we added the conversion metrics of the number of messages, and the metrics of message conversion time is still very useful. (cherry picked from commit 9f92401)
BewareMyPower
added
doc-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR #845, we added the conversion metrics of the number of messages, and the metrics of message conversion time is still very useful.
If this PR is accepted, I will add the relevant doc.