This repository was archived by the owner on Jan 24, 2024. It is now read-only.
[FEATURE] Add message conversions metrics for prometheus metrics#845
Merged
BewareMyPower merged 8 commits intostreamnative:masterfrom Nov 2, 2021
Merged
Conversation
|
|
Contributor
Author
|
@BewareMyPower @Demogorgon314 PTAL, Thanks. :) |
Contributor
Author
|
Known flaky test: #809 |
BewareMyPower
approved these changes
Nov 1, 2021
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandler.java
Outdated
Show resolved
Hide resolved
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandler.java
Outdated
Show resolved
Hide resolved
BewareMyPower
suggested changes
Nov 1, 2021
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandler.java
Outdated
Show resolved
Hide resolved
BewareMyPower
approved these changes
Nov 2, 2021
BewareMyPower
pushed a commit
that referenced
this pull request
Nov 5, 2021
### Motivation Starting from [KIP-188](https://cwiki.apache.org/confluence/display/KAFKA/KIP-188+-+Add+new+metrics+to+support+health+checks#KIP188Addnewmetricstosupporthealthchecks-Messageconversionrateandtime), Kafka has added monitoring indicators for message conversion. The reason is that because the entire response must be read into memory for conversion, the cost of down conversion is high. It is useful to monitor the conversion rate and the time it takes to convert. Therefore, it is very useful to add the same monitoring indicators in kop. ### Modifications Add the following two indicators to monitor the number of messages converted by Topic messages during production and the number of messages converted by Topic messages during consumption. `kop_server_PRODUCE_MESSAGE_CONVERSIONS` `kop_server_CONSUMER_MESSAGE_CONVERSIONS`
BewareMyPower
pushed a commit
that referenced
this pull request
Nov 5, 2021
### Motivation Starting from [KIP-188](https://cwiki.apache.org/confluence/display/KAFKA/KIP-188+-+Add+new+metrics+to+support+health+checks#KIP188Addnewmetricstosupporthealthchecks-Messageconversionrateandtime), Kafka has added monitoring indicators for message conversion. The reason is that because the entire response must be read into memory for conversion, the cost of down conversion is high. It is useful to monitor the conversion rate and the time it takes to convert. Therefore, it is very useful to add the same monitoring indicators in kop. ### Modifications Add the following two indicators to monitor the number of messages converted by Topic messages during production and the number of messages converted by Topic messages during consumption. `kop_server_PRODUCE_MESSAGE_CONVERSIONS` `kop_server_CONSUMER_MESSAGE_CONVERSIONS`
BewareMyPower
pushed a commit
that referenced
this pull request
Jan 18, 2022
In PR #845, we added the conversion metrics of the number of messages, and the metrics of message conversion time is still very useful.
BewareMyPower
pushed a commit
that referenced
this pull request
Jan 23, 2022
In PR #845, we added the conversion metrics of the number of messages, and the metrics of message conversion time is still very useful.
BewareMyPower
pushed a commit
that referenced
this pull request
Jan 23, 2022
In PR #845, we added the conversion metrics of the number of messages, and the metrics of message conversion time is still very useful.
BewareMyPower
pushed a commit
that referenced
this pull request
Feb 9, 2022
eolivelli
pushed a commit
to eolivelli/kop
that referenced
this pull request
Feb 24, 2022
…eamnative#1016) In PR streamnative#845, we added the conversion metrics of the number of messages, and the metrics of message conversion time is still very useful. (cherry picked from commit 9f92401)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Starting from KIP-188, Kafka has added monitoring indicators for message conversion. The reason is that because the entire response must be read into memory for conversion, the cost of down conversion is high. It is useful to monitor the conversion rate and the time it takes to convert.
Therefore, it is very useful to add the same monitoring indicators in kop.
Modifications
Add the following two indicators to monitor the number of messages converted by Topic messages during production and the number of messages converted by Topic messages during consumption.
kop_server_PRODUCE_MESSAGE_CONVERSIONSkop_server_CONSUMER_MESSAGE_CONVERSIONS