This repository was archived by the owner on Jan 24, 2024. It is now read-only.
[FEATURE] Support non-partitioned Topic #690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demogorgon314
changed the title
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaTopicManager.java
Show resolved
Hide resolved
Demogorgon314
force-pushed
the
support-non-partitioned-topic
branch
from
ef9941e to
e365330
Compare
BewareMyPower
approved these changes
Sep 2, 2021
BewareMyPower
pushed a commit
that referenced
this pull request
Sep 8, 2021
Fix #674 ## Motivation Some users want to use exists non-partitioned topic in KoP, so we need support the feature. ## Modifications **Note**: Current don't support transaction. When KoP handle `METADATA` request, if the topic is non-partitioned topic, then treat as a single partitioned topic. And when we `KafkaTopicManager#getTopic`, add a fallback to get non-partitioned topic. Also when namespace `load` or `unload`, we need clear the cache.
BewareMyPower
added a commit
that referenced
this pull request
Sep 30, 2021
…760) ### Motivation #690 supports non-partitioned topics and #742 supports multiple listeners and marks some configs as deprecated, so the current documents are outdated. ### Modification Even if KoP supports non-partitioned topics now, it's still better to configure `allowAutoTopicCreationType` with `partitioned` by default. This PR modified the explanation for the reason. This PR also adds docs for how to enable multiple listeners and updates the related configuration docs. In addition, #742 marks `kafkaListenerName` as deprecated, but it also makes this config not work anymore. So this PR removes the config and related tests.
BewareMyPower
added a commit
that referenced
this pull request
Sep 30, 2021
…760) ### Motivation #690 supports non-partitioned topics and #742 supports multiple listeners and marks some configs as deprecated, so the current documents are outdated. ### Modification Even if KoP supports non-partitioned topics now, it's still better to configure `allowAutoTopicCreationType` with `partitioned` by default. This PR modified the explanation for the reason. This PR also adds docs for how to enable multiple listeners and updates the related configuration docs. In addition, #742 marks `kafkaListenerName` as deprecated, but it also makes this config not work anymore. So this PR removes the config and related tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #674
Motivation
Some users want to use exists non-partitioned topic in KoP, so we need support the feature.
Modifications
Note: Current don't support transaction.
When KoP handle
METADATArequest, if the topic is non-partitioned topic, then treat as a single partitioned topic. And when weKafkaTopicManager#getTopic, add a fallback to get non-partitioned topic. Also when namespaceloadorunload, we need clear the cache.