This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Update docs for multiple listeners and non-partitioned topic support #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@Anonymitaet Please take a look at the doc part. If you have any question, please ping me. |
Anonymitaet
reviewed
Sep 28, 2021
Anonymitaet
reviewed
Sep 28, 2021
Anonymitaet
reviewed
Sep 28, 2021
Contributor
Anonymitaet
left a comment
Anonymitaet
left a comment
There was a problem hiding this comment.
@BewareMyPower Overall looks good, just leave some minor edits, PTAL.
@jennifer88huang since you are the owner of StreamNative Platform, could you help review? Thanks
Collaborator
Author
|
@Anonymitaet comments are addressed, PTAL again. |
Anonymitaet
approved these changes
Sep 29, 2021
Jennifer88huang-zz
approved these changes
Sep 30, 2021
Contributor
Jennifer88huang-zz
left a comment
Jennifer88huang-zz
left a comment
There was a problem hiding this comment.
@BewareMyPower Good job~
I've made some minor edits, you can merge this PR after refining those comments. Any issue, feel free to ping me. Thank you.
Collaborator
Author
|
I've addressed the comments, PTAL @jennifer88huang |
BewareMyPower
added a commit
that referenced
this pull request
Sep 30, 2021
…760) ### Motivation #690 supports non-partitioned topics and #742 supports multiple listeners and marks some configs as deprecated, so the current documents are outdated. ### Modification Even if KoP supports non-partitioned topics now, it's still better to configure `allowAutoTopicCreationType` with `partitioned` by default. This PR modified the explanation for the reason. This PR also adds docs for how to enable multiple listeners and updates the related configuration docs. In addition, #742 marks `kafkaListenerName` as deprecated, but it also makes this config not work anymore. So this PR removes the config and related tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#690 supports non-partitioned topics and #742 supports multiple listeners and marks some configs as deprecated, so the current documents are outdated.
Modification
Even if KoP supports non-partitioned topics now, it's still better to configure
allowAutoTopicCreationTypewithpartitionedby default. This PR modified the explanation for the reason.This PR also adds docs for how to enable multiple listeners and updates the related configuration docs.
In addition, #742 marks
kafkaListenerNameas deprecated, but it also makes this config not work anymore. So this PR removes the config and related tests.