This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Multi tenant configuration - fix handling of group management topics tenant #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Member
Demogorgon314
left a comment
Demogorgon314
left a comment
There was a problem hiding this comment.
Overall LGTM. Just left few comment. PTAL.
...rc/main/java/io/streamnative/pulsar/handlers/kop/coordinator/group/GroupMetadataManager.java
Outdated
Show resolved
Hide resolved
...rc/main/java/io/streamnative/pulsar/handlers/kop/coordinator/group/GroupMetadataManager.java
Outdated
Show resolved
Hide resolved
...rc/main/java/io/streamnative/pulsar/handlers/kop/coordinator/group/GroupMetadataManager.java
Outdated
Show resolved
Hide resolved
| @@ -1154,6 +1158,7 @@ public void removeGroupsForPartition(int offsetsPartition, | |||
| TopicPartition topicPartition = new TopicPartition( | |||
| GROUP_METADATA_TOPIC_NAME, offsetsPartition | |||
Member
There was a problem hiding this comment.
I guess this topic name need change too, it will make log more accurate.
| @Default | ||
| private String offsetsTopicName = DefaultOffsetsTopicName; | ||
|
|
||
| public String getCurrentOffsetsTopicName(String tenant) { |
Member
There was a problem hiding this comment.
IMO, We can replace placeholder when OffsetConfig object creating, Instead of replacing placeholder every time we get it.
Contributor
Author
There was a problem hiding this comment.
it makes sense to me.
But I have to perform some refactors.
I will update the patch in the next days
Contributor
Author
|
After rebasing to current master this patch is useless. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OffsetConfig was still using "public" as tenant
Changes: