-
Notifications
You must be signed in to change notification settings - Fork 142
Transactions: implement support for JWT token authentication between brokers #941
Conversation
|
@Demogorgon314 @BewareMyPower |
|
@Demogorgon314 in my fork the test is passing. This patch #849 fixes a problem with Multi-Tenant configuration and SASL, but it is not enough to make the test pass. Today I will update #849 and address your comments, so that our codebase will be more one close to each other |
|
it looks like #849 is not needed. in my fork I am missing the latest refactor about ReplicaManager, probably that's the cause. can you help me in debugging the failure ? |
|
@eolivelli First of all, you need rebase master onto the current branch, then set |
Demogorgon314
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice work!
…brokers (#941) **Motivation** When you enable JWT token authentication transactions do not work because transactions need broker-to-broker communication but there is currently no support for the SASL handshake. **Changes** Now when you enable authentication and you configure Token Authentication for Broker-To-Broker communications in Pulsar, we perform SASL PLAIN authentication while preparing the connection to other brokers. **Tests** I have extended existing SASL tests in order to use Transactions. I have copy/pasted some parts of the TransactionTest, but there was not enough code to make sense to share the test code.
…brokers (#941) **Motivation** When you enable JWT token authentication transactions do not work because transactions need broker-to-broker communication but there is currently no support for the SASL handshake. **Changes** Now when you enable authentication and you configure Token Authentication for Broker-To-Broker communications in Pulsar, we perform SASL PLAIN authentication while preparing the connection to other brokers. **Tests** I have extended existing SASL tests in order to use Transactions. I have copy/pasted some parts of the TransactionTest, but there was not enough code to make sense to share the test code. Fix conflicts made by #864, which changes the signature of `lookupBroker`.
Motivation
When you enable JWT token authentication transactions do not work because transactions need broker-to-broker communication but there is currently no support for the SASL handshake.
Changes
Now when you enable authentication and you configure Token Authentication for Broker-To-Broker communications in Pulsar, we perform SASL PLAIN authentication while preparing the connection to other brokers.
Tests
I have extended existing SASL tests in order to use Transactions. I have copy/pasted some parts of the TransactionTest, but there was not enough code to make sense to share the test code.