Skip to content

Add default RID to Windows, TargetFramework and global.json project template #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xen2 merged 3 commits into from
Nov 16, 2020
Merged

Add default RID to Windows, TargetFramework and global.json project template #910

xen2 merged 3 commits into from
Nov 16, 2020

Conversation

@manio143
Copy link
Member

@manio143 manio143 commented Nov 15, 2020 •
edited
Loading

PR Details

Description

  • Adds the windows RID to executable project template, so that when someone changes target framework to netcoreapp3.1 they aren't immediately hit with freetype.dll missing exception.
  • Setup Windows project to use .NET Core if created from .NET Core GameStudio
  • Add global.json when using .NET Core GameStudio

Related Issue

#911

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@manio143 manio143 mentioned this pull request Nov 15, 2020
Closed
@manio143 manio143 changed the title Add default RID to Windows project template Add default RID to Windows, TargetFramework and global.json project template Nov 15, 2020
@xen2 xen2 merged commit e20bdf3 into stride3d:master Nov 16, 2020
@thargy thargy mentioned this pull request Dec 6, 2020
Closed
thargy added a commit to DevDecoder/Xenko.CustomRootRenderFeature that referenced this pull request Dec 6, 2020
@thargy
Updated to run on .NET Core 3.1.
ccf8703 
(see stride3d/stride#837, and stride3d/stride#910)
@manio143 manio143 mentioned this pull request Dec 7, 2020
Closed
@thargy
Copy link

thargy commented Dec 7, 2020 •
edited
Loading

Note that the requirement to inject global.json may be negated by any fix to this MSBuild bug.

The fix for that bug is being considered for release in VS 16.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@manio143 @thargy @xen2