Deprecate built-in CORS middleware #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Push the responsibility of enabling/configuring CORS back to the application developer.
bajtos
commented
Sep 21, 2016
| it('can be disabled by configuration', function(done) { | ||
| var app = loopback(); | ||
| app.set('remoting', { cors: { origin: false }}); | ||
| app.set('remoting', { cors: false }); |
Member
Author
There was a problem hiding this comment.
This change is needed to fix npm test when using LB 3.x. Before, the tests were failing because remoting.cors was rejected by LB 3.x runtime.
Contributor
|
Don't understand why it's necessary to test everything with |
This was referenced Sep 22, 2016
Member
Author
Let's discuss here: strongloop/strong-remoting#357 (comment) |
This was referenced Sep 22, 2016
richardpringle
approved these changes
Sep 22, 2016
Contributor
|
Approved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Push the responsibility of enabling/configuring CORS back to the application developer.
This is a follow-up for strongloop/strong-remoting#352 and strongloop/strong-remoting#357 which removed (3.x)/deprecated (2.x) the built-in CORS middleware in strong-remoting.
@richardpringle please review