-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Expose new method for disabling remote methods. #2758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@slnode test please |
|
We can either land this or #2767 |
|
+1 for adding a new API that's consistent with strong-remoting API. Could you please add a unit-test? At least copy & modify the existing test here that verifies As for the existing
See how |
bajtos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL on my comment above.
0e4993f to
0ab33a8
Compare
|
@bajtos changes have been made as per your request |
|
All three failed Windows builds are caused by |
|
The loopback-component-explorer failure is unrelated, see strongloop/loopback-component-explorer#178 |
|
Landed, thank you @richardpringle. Could you please back-port the new API to 2.x (without the deprecation notice)? |
|
@richardpringle we have a unit-test in loopback-component-explorer that's triggering a deprecation warning, could you PTAL? Because the same version of loopback-component-explorer is supporting both LB 2.x and LB 3.x, it will be best to have the new API backported to 2.x, so that the tests in explorer can rely on this new API. |
backport -> #2781 LB-component-explorer PR -> strongloop/loopback-component-explorer#181 |
There is a new
SharedClassmethod available in strong-remoting for disabling a method by name instead of specifying theisStaticboolean.I have exposed the method on the
ModelClass such that it can be used for a spike related to #651.@bajtos, please review