Skip to content

Call new disable remote method from model class [2.x] #2781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
richardpringle merged 1 commit into from
Sep 26, 2016
Merged

Call new disable remote method from model class [2.x] #2781

richardpringle merged 1 commit into from
Sep 26, 2016

Conversation

@richardpringle
Copy link
Contributor

@richardpringle richardpringle commented Sep 22, 2016 •
edited
Loading

backport of 0ab33a8

@richardpringle richardpringle mentioned this pull request Sep 22, 2016
Merged
@richardpringle richardpringle force-pushed the backport/disableMethodByName branch from e1ec15c to 4ee3660 Compare September 22, 2016 19:28
superkhau
superkhau approved these changes Sep 22, 2016
View reviewed changes
Copy link
Contributor

@superkhau superkhau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good -- Please ping @rmg to figure whats up with the loopback failure -- I think it's unrelated.

@superkhau
Copy link
Contributor

superkhau commented Sep 22, 2016

@richardpringle Add note for you to remember to remove the deprecation message in the backport too.

@bajtos bajtos changed the title Call new disable remote method from model class. Call new disable remote method from model class [2.x] Sep 23, 2016
bajtos
bajtos suggested changes Sep 23, 2016
View reviewed changes
test/model.test.js
var TestModel = app.models.TestModelForDisablingRemoteMethod;
TestModel.on('remoteMethodDisabled', callbackSpy);
TestModel.disableRemoteMethod('findOne');
TestModel.disableRemoteMethod('findOne', true);
Copy link
Member

@bajtos bajtos Sep 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 2.x, the method disableRemoteMethod is not deprecated. Can we place keep this test unmodified to cover this API?

@richardpringle richardpringle mentioned this pull request Sep 23, 2016
Merged
@richardpringle
Copy link
Contributor Author

richardpringle commented Sep 23, 2016

@bajtos, findOne is a static method, the true should have always been there.

@bajtos
Copy link
Member

bajtos commented Sep 23, 2016

@bajtos, findOne is a static method, the true should have always been there.

Ah, I see, you are right.

bajtos
bajtos approved these changes Sep 23, 2016
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@richardpringle richardpringle force-pushed the backport/disableMethodByName branch from 4ee3660 to f7dbc97 Compare September 23, 2016 15:15
@richardpringle
Copy link
Contributor Author

richardpringle commented Sep 23, 2016

@bajtos, shit should be okay to merge right? Those windows builds aren't failing anymore and it doesn't seam like the failed tests for the downstream buils have anything to do with this change.

@superkhau
Copy link
Contributor

superkhau commented Sep 23, 2016 •
edited
Loading

FYI, skipping multitenancy tests to get CI green at strongloop/loopback-multitenancy#11.

@bajtos
Copy link
Member

bajtos commented Sep 26, 2016

@slnode test please

@bajtos
Copy link
Member

bajtos commented Sep 26, 2016

okay to merge right? Those windows builds aren't failing anymore and it doesn't seam like the failed tests for the downstream buils have anything to do with this change.

Agreed, go ahead and :shipit:

@richardpringle richardpringle merged commit 4a0835a into 2.x Sep 26, 2016
@richardpringle richardpringle deleted the backport/disableMethodByName branch September 26, 2016 15:56
@c3s4r c3s4r mentioned this pull request Dec 12, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@bajtos bajtos bajtos approved these changes

@superkhau superkhau superkhau approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@richardpringle @superkhau @bajtos