fix a multiuser owership problem #3865
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if principalType is 'Patient' and userModelName is 'Doctor' then callback is never called
vanceeasleaf
requested review from
bajtos,
clark0x,
ebarault,
fabien and
zbarbuto
as code owners
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
Member
|
Hi there, thanks for the PR! I’m not seeing how this particular change fixed an issue. Could you please add a test case or two that fail without your change and pass with it? Thanks. |
Member
|
Closing as a duplicate of #3883. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
if principalType is 'Patient' and userModelName is 'Doctor' then callback is never called
Checklist