Fix isOwner() bug in multiple-principal setup #3883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
This was referenced May 18, 2018
Fix the owner role resolver to correctly handle the case when a user from one model (e.g. Seller) is accessing an instance of another user-like model (e.g. Customer).
bajtos
force-pushed
the
fix/principal-type-polymorphic-user
branch
from
ef17bb5 to
2aead13
Compare
raymondfeng
approved these changes
May 18, 2018
Member
Author
|
Published in |
2 tasks
|
@bajtos Great! Good work guys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the owner role resolver to correctly handle the case when a user from one model (e.g. Seller) is accessing an instance of another user-like model (e.g. Customer).
This PR supersedes #3823, #3679 and possible other older PRs. The change may be related to #3644.
@akki-ng @MartinCerny-awin could you please give this a try and let us know if the patch fixes the problem for you?
Checklist
guide