With schedules#72
Merged
Merged
Conversation
ignacio-pm
approved these changes
Aug 15, 2022
Collaborator
There was a problem hiding this comment.
Python implementation looks well-coded and usable. Demo and README help understand the changes. However, I do not have a major knowledge on how the whole implementation in Python works and I have not tested it. Some minor comments are written in the review.
Owner
Author
|
Thank you @ignacio-pm for the code review! Especially for pointing out features of the code that should be improved in several classes, beyond the ones in this PR. |
Collaborator
|
Thank you for creating and maintaining this repository! I do not plan to use it again in the short term, but many people will find it helpful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch implements the new DmpWithSchedules class.
https://github.com/stulp/dmpbbo/blob/with_schedules/dmpbbo/dmps/DmpWithSchedules.py
It also includes a demo that shows how gains are optimized in stochastic and constant force fields:
https://github.com/stulp/dmpbbo/blob/with_schedules/demos/python/bbo_of_dmps/with_schedules/README.md