Updating some of the NEMO viscous solver routines. #1347

WallyMaier · 2021-08-04T17:29:06Z

Proposed Changes

This PR updates some of the NEMO viscous routines to be more inline with the overall SU2 structure. Hopefully paving the way for an easier merge with turbulence solvers in the future.

Related Work

This is coming with an effort to update and optimize NEMO, like in #1343.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

I am submitting my contribution to the develop branch.
My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
My contribution is commented and consistent with SU2 style.
I have added a test case that demonstrates my contribution, if necessary.
I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

lgtm-com · 2021-08-04T18:18:12Z

This pull request fixes 1 alert when merging eab6dcd into f47e22b - view on LGTM.com

fixed alerts:

1 for Comparison of narrow type with wide type in loop condition

lgtm-com · 2021-08-04T19:48:48Z

This pull request fixes 1 alert when merging 210fefc into f47e22b - view on LGTM.com

fixed alerts:

1 for Comparison of narrow type with wide type in loop condition

…o nemo_visc_update

lgtm-com · 2021-08-05T02:47:23Z

This pull request fixes 1 alert when merging aceb911 into f47e22b - view on LGTM.com

fixed alerts:

1 for Comparison of narrow type with wide type in loop condition

pcarruscag

Thanks for the cleanup and modernization 👍, just a few comments below, one might be an issue (but easy to fix).

SU2_CFD/include/solvers/CFVMFlowSolverBase.hpp

SU2_CFD/src/fluid/CNEMOGas.cpp

SU2_CFD/src/solvers/CNEMONSSolver.cpp

…o nemo_visc_update

lgtm-com · 2021-08-17T19:32:29Z

This pull request fixes 1 alert when merging 9d086ab into 3ec1c68 - view on LGTM.com

fixed alerts:

1 for Comparison of narrow type with wide type in loop condition

pcarruscag

Thanks Wally, you got some changes in codi and opdi by accident.
Revert those and this is good to go for me 👍

pcarruscag · 2021-08-17T22:09:51Z

The versions you want are:
codi 3c3211fef2e225ab89680a4063b62bb3bb38a7e4
opdi 2735b503f60163e8d64e1ac56cce46173a9fd4a9

WallyMaier · 2021-08-17T22:17:49Z

@pcarruscag Thats interesting, I just crossed check the versions in my init.py file and they match the versions you posted. Im not sure what how to revert these changes :(

pcarruscag · 2021-08-17T22:21:49Z

checkout those commits I mentioned (by going inside externals/codi and externals/opdi) and then commit again and push

lgtm-com · 2021-08-17T23:20:19Z

This pull request fixes 1 alert when merging bc7aa7a into 3ec1c68 - view on LGTM.com

fixed alerts:

1 for Comparison of narrow type with wide type in loop condition

WallyMaier · 2021-08-17T23:22:57Z

Thanks! It looks like I needed to update a regression with change...strange. But its done.

lgtm-com · 2021-08-18T00:30:24Z

This pull request fixes 1 alert when merging 7a487f2 into 3ec1c68 - view on LGTM.com

fixed alerts:

1 for Comparison of narrow type with wide type in loop condition

jtneedels · 2021-08-18T04:37:15Z

SU2_CFD/src/solvers/CIncNSSolver.cpp

    SetPrimitive_Limiter(geometry, config);
  }

-  ComputeVorticityAndStrainMag<1>(*config, iMesh);


What did the <1> here signify?

It was part of a way to make a general function for all solvers. It is essentially VEL_INDEX

unknown and others added 4 commits August 4, 2021 10:34

updating the 'solvers'

1e802f8

some variable + solver changes for compilation

1c3556f

fixing heatflux bc bug

f831c11

update some NS boundary conditions

5cd81de

pr-triage bot added the PR: draft label Aug 4, 2021

small cleanup

eab6dcd

unknown and others added 2 commits August 4, 2021 14:58

fixed vel2 bug

e208415

Fix compiling errors

210fefc

WallyMaier added 2 commits August 4, 2021 22:00

closing OMP stuff

66f6100

Merge branch 'nemo_visc_update' of https://github.com/su2code/SU2 int…

aceb911

…o nemo_visc_update

WallyMaier added the changelog:chore label Aug 5, 2021

WallyMaier changed the title ~~[WIP] Updating some of the NEMO viscous solver routines.~~ Updating some of the NEMO viscous solver routines. Aug 5, 2021

pcarruscag marked this pull request as ready for review August 7, 2021 08:44

pr-triage bot added PR: unreviewed and removed PR: draft labels Aug 7, 2021

pcarruscag approved these changes Aug 7, 2021

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels Aug 7, 2021

WallyMaier mentioned this pull request Aug 11, 2021

NEMO - Improvements on the Preprocessing phase and inclusion of Chapmann-Enskog for Mutation++ #1343

Merged

pcarruscag changed the title ~~Updating some of the NEMO viscous solver routines.~~ [WIP] Updating some of the NEMO viscous solver routines. Aug 16, 2021

pr-triage bot removed the PR: reviewed-approved label Aug 16, 2021

WallyMaier and others added 3 commits August 17, 2021 11:08

addressing PR comments

9c6ac28

Merge remote-tracking branch 'origin/develop' into nemo_visc_update

255b43f

updating version numbers

7250fb2

WallyMaier requested review from fmpmorgado and jtneedels August 17, 2021 18:30

removing unused var

8899172

Merge branch 'nemo_visc_update' of https://github.com/su2code/SU2 int…

9d086ab

…o nemo_visc_update

WallyMaier changed the title ~~[WIP] Updating some of the NEMO viscous solver routines.~~ Updating some of the NEMO viscous solver routines. Aug 17, 2021

pr-triage bot added the PR: unreviewed label Aug 17, 2021

pcarruscag reviewed Aug 17, 2021

View reviewed changes

update codi and opdi

bc7aa7a

updating regression for heated_cylinder

d9674e5

redoing cylinder regression values....github is confused

7a487f2

jtneedels reviewed Aug 18, 2021

View reviewed changes

jtneedels approved these changes Aug 18, 2021

View reviewed changes

pr-triage bot added PR: partially-approved and removed PR: unreviewed labels Aug 18, 2021

WallyMaier mentioned this pull request Aug 21, 2021

[WIP] Test for adding in the implicit viscous solver for NEMO #1356

Closed

5 tasks

WallyMaier merged commit c2c78e2 into develop Aug 21, 2021

WallyMaier deleted the nemo_visc_update branch August 21, 2021 16:32

pr-triage bot added the PR: merged label Aug 21, 2021

WallyMaier mentioned this pull request Oct 9, 2021

Implicit solver for inviscid NEMO problems #1399

Merged

5 tasks

WallyMaier mentioned this pull request Nov 3, 2021

Implementation of Implicit for viscous NEMO problems #1422

Merged

5 tasks

Updating some of the NEMO viscous solver routines. #1347

Updating some of the NEMO viscous solver routines. #1347

Uh oh!

Conversation

WallyMaier commented Aug 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Related Work

PR Checklist

Uh oh!

lgtm-com bot commented Aug 4, 2021

Uh oh!

lgtm-com bot commented Aug 4, 2021

Uh oh!

lgtm-com bot commented Aug 5, 2021

Uh oh!

pcarruscag left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lgtm-com bot commented Aug 17, 2021

Uh oh!

pcarruscag left a comment

Choose a reason for hiding this comment

Uh oh!

pcarruscag commented Aug 17, 2021

Uh oh!

WallyMaier commented Aug 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pcarruscag commented Aug 17, 2021

Uh oh!

lgtm-com bot commented Aug 17, 2021

Uh oh!

WallyMaier commented Aug 17, 2021

Uh oh!

lgtm-com bot commented Aug 18, 2021

Uh oh!

jtneedels Aug 18, 2021

Choose a reason for hiding this comment

Uh oh!

WallyMaier Aug 18, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

WallyMaier commented Aug 4, 2021 •

edited

Loading

WallyMaier commented Aug 17, 2021 •

edited

Loading