Implementation of Implicit for viscous NEMO problems #1422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WallyMaier
commented
Nov 3, 2021
|
This pull request introduces 1 alert and fixes 16 when merging 2ebda7e into 262f439 - view on LGTM.com new alerts:
fixed alerts:
|
jtneedels
approved these changes
Nov 3, 2021
pcarruscag
reviewed
Nov 3, 2021
|
This pull request introduces 2 alerts and fixes 16 when merging 6b97520 into 262f439 - view on LGTM.com new alerts:
fixed alerts:
|
pcarruscag
approved these changes
Nov 6, 2021
Member
pcarruscag
left a comment
pcarruscag
left a comment
There was a problem hiding this comment.
Thanks for the extra cleanup. Just a couple minor suggestions below and then LGTM.
|
This pull request introduces 2 alerts and fixes 16 when merging b70962c into 147dfac - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 2 alerts and fixes 16 when merging 01103cb into 641d254 - view on LGTM.com new alerts:
fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR introduces the implicit time-stepping capability for viscous problems using NEMO.
The is a "clean" of PR #1356 (which should be closed by the time you read this). Most of the implementation discussion can be found there. Thanks to @pcarruscag for helping modernize the approach taken!
There are also several small fixes throughout addressing some LGTM.com and codefactor issues.
Future work will include extracting Jacobians from the Mutation++ to be used with NEMO. As of right now, only the native library can be used with the implementation.
Related Work
Related PRs include #1356, #1343, and #1347.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.