Adding inlet markers for turbulent intensity and viscosity ratio for SST Model #1843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
November 18, 2022 15:36
bigfooted
reviewed
Dec 5, 2022
bigfooted
reviewed
Dec 5, 2022
bigfooted
reviewed
Dec 5, 2022
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
pcarruscag
reviewed
Dec 5, 2022
Co-authored-by: Nijso <bigfootedrockmidget@hotmail.com>
bigfooted
reviewed
Dec 6, 2022
bigfooted
reviewed
Dec 6, 2022
Co-authored-by: Nijso <bigfootedrockmidget@hotmail.com>
Co-authored-by: Nijso <bigfootedrockmidget@hotmail.com>
bigfooted
reviewed
Dec 8, 2022
...sport/venturi_primitive_3species/species2_primitiveVenturi_mixingmodel_TURBULENT_MARKERS.cfg
Outdated
Show resolved
Hide resolved
…2_primitiveVenturi_mixingmodel_TURBULENT_MARKERS.cfg Co-authored-by: Nijso <bigfootedrockmidget@hotmail.com>
Contributor
|
@Cristopher-Morales I guess it's ready, if you also think so, please remove the WIP from the title |
Cristopher-Morales
changed the title
Contributor
|
Can you add the keyword to config_template.cfg as well? |
WallyMaier
approved these changes
Dec 8, 2022
Contributor
WallyMaier
left a comment
WallyMaier
left a comment
There was a problem hiding this comment.
This looks good to me!
pcarruscag
reviewed
Dec 8, 2022
...sport/venturi_primitive_3species/species2_primitiveVenturi_mixingmodel_TURBULENT_MARKERS.cfg
Outdated
Show resolved
Hide resolved
pcarruscag
approved these changes
Dec 8, 2022
…2_primitiveVenturi_mixingmodel_TURBULENT_MARKERS.cfg Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
In this pull request, we aim to add the option of turbulent intensity and ratio turbulent to laminar viscosity per inlet for the SST model as follows:
MARKER_INLET_TURBULENT= (Inlet_1, TurbIntensity_1, ViscRatio_1, Inlet_2, TurbIntensity_2, ViscRatio_2,......)
In the case that the inlet markers are not provided, we aim to keep the current SU2 implementation.
Related Work
This pull request is related to the previous pull request #1796
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.