Skip to content

Conversation

@Cristopher-Morales
Copy link
Contributor

Proposed Changes

Give a brief overview of your contribution here in a few sentences.

Following to what was done in the pull request #1796 , we aim with this pull request to use the known fluid properties at the inlets in order to set the BC for the SA model. Also, we extent the use of the turbulent marker options for this case as It was done in the previous pull request for SST #1843.
I can add a test case if it is needed.

Related Work

related to pull request #1796 , #1843

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pcarruscag pcarruscag changed the title [WIP] BC inlet for SA solver based on local conditions at the Inlet BC inlet for SA solver based on local conditions at the Inlet Mar 9, 2023
Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if you need to update the config template or any doc on the website.
It would also be good to modify an existing test case to exercise this feature.

Cristopher-Morales and others added 2 commits March 9, 2023 21:07
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
@Cristopher-Morales
Copy link
Contributor Author

Check if you need to update the config template or any doc on the website. It would also be good to modify an existing test case to exercise this feature.

Thank you so much for your comment. Yes, I will update the website with this additional feature. I will modify one of the existing test cases in this pull request.

@Cristopher-Morales Cristopher-Morales merged commit 12e09d3 into develop Mar 10, 2023
@Cristopher-Morales Cristopher-Morales deleted the feature_BC_INLET_SA branch March 10, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants