refactor: extract shared polling loop from GetGraph and GetCircularDependencies in api/client.go

[claude]

GetGraph (lines 265–397) and GetCircularDependencies (lines 399–534) in internal/api/client.go each contain ~130 lines of near-identical async polling logic. Both methods:

• Build a multipart request body
• Generate an idempotency key
• Poll in a loop, checking ctx.Done(), a deadline, and maxPollAttempts
• Handle HTTP status codes identically (401, 402, 429, 404/405, 200/202, default)
• Parse a JobStatus envelope and branch on completed / failed / pending / processing
• Sleep for retryAfter seconds between attempts

Only the endpoint URL and the result-parsing step differ.

Impact

Any change to retry behavior, backoff, or error handling must be made in two places. This has already diverged subtly (e.g. 404/405 is only handled in GetCircularDependencies).

Proposed Fix

Extract a pollJob helper that accepts endpoint URL, the pre-built multipart body/content-type, and a parseResult func(*json.RawMessage) error callback. Both public methods become thin wrappers:

func (c *Client) pollJob(
    ctx context.Context,
    endpoint string,
    bodyBytes []byte,
    contentType string,
    idempotencyKey string,
    onComplete func(*json.RawMessage) error,
    notFound func() error,
) error

Files

• internal/api/client.go lines 265–534

@claude please implement this

[claude]

Claude finished @claude[bot]'s task in 4m 56s —— View job • claude/issue-41-20260227-0442 • [Create PR ➔](https://github.com/supermodeltools/Uncompact/compare/main...claude/issue-41-20260227-0442?quick_pull=1&title=Issue%20%2341%3A%20Changes%20from%20Claude&body=This%20PR%20addresses%20issue%20%2341%0A%0AGenerated%20with%20%5BClaude%20Code%5D(https%3A%2F%2Fclaude.ai%2Fcode)

---

Implementing refactor: extract shared polling loop

• Gather context and understand the request
• Read internal/api/client.go (lines 265–534)
• Implement buildMultipartBody helper and pollJob method
• Refactor GetGraph to use pollJob
• Refactor GetCircularDependencies to use pollJob
• Verify go build ./... and go vet ./... pass
• Commit and push
• Create PR

What was done

Extracted two helpers from the 270-line duplicate block in internal/api/client.go:

buildMultipartBody(projectName, repoZip) — Builds the multipart/form-data request body once per call, removing the identical 10-line block from both methods.

pollJob(ctx, endpoint, bodyBytes, contentType, idempotencyKey, onComplete, notFound) — Contains all shared polling logic:

• Deadline and maxPollAttempts guard
• ctx.Done() checks throughout
• HTTP request construction and dispatch
• Status-code handling (401, 402, 429, 404/405 via notFound callback, 200/202, default error)
• JobStatus envelope parsing and branching on completed/failed/pending/processing
• Retry sleep with retryAfter

GetGraph and GetCircularDependencies are now ~15-line thin wrappers. The 404/405 divergence noted in the issue is resolved: GetCircularDependencies passes func() error { return nil } as notFound, while GetGraph passes nil (causing 404/405 to fall through to the default API error, matching its original behaviour).

Net result: 98 insertions, 170 deletions — 72 lines removed.

View PR #45 |

[coderabbitai]

🔗 Related PRs

#18 - feat: show circular dependency warning in context bomb [merged]

---

📝 Issue Planner

_{Check the box below or use the @coderabbitai plan command to generate an implementation plan and prompts that you can use with your favorite coding assistant.}

• Create Plan

---

🧪 Issue enrichment is currently in open beta.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord!