refactor: extract shared polling loop into pollJob helper#45
Merged
claude[bot] merged 1 commit intomainfrom Feb 27, 2026
Merged
refactor: extract shared polling loop into pollJob helper#45claude[bot] merged 1 commit intomainfrom
claude[bot] merged 1 commit intomainfrom
Conversation
Extract buildMultipartBody and pollJob from the duplicated logic in GetGraph and GetCircularDependencies. Both public methods are now thin wrappers: they build the request body, then delegate all polling, HTTP status handling, and job-status branching to pollJob via callbacks. The 404/405 case (previously only in GetCircularDependencies) is now handled uniformly via a notFound callback, so future endpoints inherit correct behaviour automatically. Co-Authored-By: Grey Newell <greyshipscode@gmail.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildMultipartBodyto eliminate the duplicated multipart body construction inGetGraphandGetCircularDependenciespollJobmethod containing all shared async polling logic: deadline/attempt checks, HTTP request dispatch, status-code handling,JobStatusenvelope parsing, and retry sleepGetGraphandGetCircularDependenciesare now thin wrappers (~15 lines each) that build the request body and pass anonCompletecallback topollJobGetCircularDependencies) is now handled uniformly via anotFound func() errorcallback, so any future endpoint naturally inherits the correct behaviourBefore: ~270 lines across two near-identical methods
After: ~100-line
pollJob+ ~30 lines of wrapper code — net reduction of 72 linesCloses #41
Generated with Claude Code