fix(playwright): move playwright install from prepare to test:e2e#1072
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: c7986f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Member
|
What happens if the browsers are already installed, though? How fast it skips? |
Contributor
Author
|
It takes less than a second |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1062
Description
Move
playwright installout of thepreparescript and intotest:e2e.prepareruns on everynpm install, including in prod / CI environments that probably don't run e2e tests. No reason to download browsers there.test:e2eties the install to the only place it's actually needed, without annoying the test launch (playwright skips when browsers are already cached).Checklist