Skip to content

fix(playwright): move playwright install from prepare to test:e2e #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jycouet merged 1 commit into from
Apr 29, 2026
+8 −3
Merged

fix(playwright): move playwright install from prepare to test:e2e #1072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/playwright-install-on-test-e2e.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'sv': patch
---

fix(playwright): move `playwright install` from `prepare` to `test:e2e` script
2 changes: 1 addition & 1 deletion packages/sv/src/addons/playwright.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ export default defineAddon({
sv.file(
file.package,
transforms.json(({ data, json }) => {
json.packageScriptsUpsert(data, 'prepare', 'playwright install', { mode: 'prepend' });
json.packageScriptsUpsert(data, 'test:e2e', 'playwright test');
json.packageScriptsUpsert(data, 'test:e2e', 'playwright install', { mode: 'prepend' });
json.packageScriptsUpsert(data, 'test', 'npm run test:e2e');
})
);
Expand Down
4 changes: 2 additions & 2 deletions packages/sv/src/cli/tests/snapshots/create-with-all-addons/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@
"dev": "vite dev",
"build": "vite build",
"preview": "vite preview",
"prepare": "playwright install && svelte-kit sync || echo ''",
"prepare": "svelte-kit sync || echo ''",
"check": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json",
"check:watch": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json --watch",
"lint": "prettier --check . && eslint .",
"format": "prettier --write .",
"test:unit": "vitest",
"test": "npm run test:unit -- --run && npm run test:e2e",
"test:e2e": "playwright test",
"test:e2e": "playwright install && playwright test",
"db:push": "drizzle-kit push",
"db:generate": "drizzle-kit generate",
"db:migrate": "drizzle-kit migrate",
Expand Down
Loading