Conversation
|
pnpm-lock.yaml
Outdated
| specifiers: | ||
| '@sveltejs/adapter-auto': workspace:* | ||
| '@sveltejs/adapter-static': workspace:^1.0.0-next.28 | ||
| '@sveltejs/adapter-static': workspace:^1.0.0-next.29 |
There was a problem hiding this comment.
The static adapter should presumably be completely removed from the kt.svelte.dev site.
There was a problem hiding this comment.
Maybe it's just happened on my local, but after removing @sveltejs/adapter-static, pnpm build is failed.
But the deployment to Vercel appears successful.
|
Can you try to merge it @Conduitry |
|
Is every project going to need I'm guessing the need for it might be related to this: #3942 (comment) |
|
@benmccann |
|
It would be nice to get rid of |
|
@Rich-Harris thanks for merging that |
|
@Rich-Harris I think you need to rerun that action that failed previously. |
|
Maybe should we swap (rebase) latest 2 commits for releasing? |
sveltejs#4011 added @sveltejs/adapter-static . But sveltejs#4239 removed it. Then deploy process is failed. (Please see sveltejs#4244 (comment) for more details)
|
Latest build doesn't run ReferenceError: require is not defined in ES module scope, you can use import instead |
* add @sveltejs/adapter-static. #4011 added @sveltejs/adapter-static . But #4239 removed it. Then deploy process is failed. (Please see #4244 (comment) for more details) * workspace:^1.0.0-next.29 -> workspace:*
Follow up: #4235
The latest release was failed due to some build configuration.
So I tried to fix it.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0