[chore] add @sveltejs/adapter-static to site package#4245
[chore] add @sveltejs/adapter-static to site package#4245Rich-Harris merged 2 commits intosveltejs:masterfrom
@sveltejs/adapter-static to site package#4245Conversation
sveltejs#4011 added @sveltejs/adapter-static . But sveltejs#4239 removed it. Then deploy process is failed. (Please see sveltejs#4244 (comment) for more details)
|
sites/kit.svelte.dev/package.json
Outdated
| }, | ||
| "devDependencies": { | ||
| "@sveltejs/adapter-auto": "workspace:*", | ||
| "@sveltejs/adapter-static": "workspace:^1.0.0-next.29", |
There was a problem hiding this comment.
| "@sveltejs/adapter-static": "workspace:^1.0.0-next.29", | |
| "@sveltejs/adapter-static": "workspace:*", |
I think this should be workspace:* like others are
There was a problem hiding this comment.
This is simply rollback to previous commit.
https://github.com/sveltejs/kit/blame/cdc32a9f4f17d69be6ca1cae58bf3961155545a2/sites/kit.svelte.dev/package.json
But workspace:* is better I think too.
pnpm-lock.yaml
Outdated
| sites/kit.svelte.dev: | ||
| specifiers: | ||
| '@sveltejs/adapter-auto': workspace:* | ||
| '@sveltejs/adapter-static': workspace:^1.0.0-next.29 |
There was a problem hiding this comment.
| '@sveltejs/adapter-static': workspace:^1.0.0-next.29 | |
| '@sveltejs/adapter-static': workspace:* |
I think this should be workspace:* like others are
|
thanks! |
Now deploy process seems failed. (e.g. https://app.netlify.com/sites/kit-demo/deploys/622468f183e8a9000860529a#L1048)
This PR fixes this issue.
Please see the below comments for more details.
#4244 (comment)
#4244 (comment)
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0