[Go] Replace .Username with .UserName in generated API methods.#3573
Merged
wing328 merged 1 commit intoswagger-api:masterfrom Aug 11, 2016
Merged
Conversation
Right now, any generated code where the http basic authentication is required is broken, as it tries to access nonexistent field in the generated `Configuration` struct. The alternative is to fix `configuration.mustache` to replace the `UserName` field with `Username` field.
Contributor
Author
|
It would be great if some Go code would be built as part of CI tests, covering this type of change. What would be a good way of tackling this? |
Contributor
|
@ivucica totally agree leveraging the CI and Go Petstore API client to catch the issue moving forward. I'll submit a PR to update the test spec. |
Contributor
|
I've added test cases via #3574 to cover the issue and got the following error before your fix: |
.Username with .UserName in generated API methods..Username with .UserName in generated API methods.
Contributor
Contributor
Author
|
This is fine. #4245 seems to also be covering my comment:
I do not understand what @paulvollmer's "the UserName variable does not work in CamelCase" means, i.e. why this is necessary, but it seems like a clean fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, any generated code where the http basic authentication is
required is broken, as it tries to access nonexistent field in the
generated
Configurationstruct.The alternative is to fix
configuration.mustacheto replace theUserNamefield withUsernamefield.