Skip to content

[Go] Fix variable naming "UserName"#4245

Merged
wing328 merged 2 commits intoswagger-api:masterfrom
paulvollmer:master
Dec 12, 2016
Merged

[Go] Fix variable naming "UserName"#4245
wing328 merged 2 commits intoswagger-api:masterfrom
paulvollmer:master

Conversation

@paulvollmer
Copy link
Copy Markdown
Contributor

@paulvollmer paulvollmer commented Nov 23, 2016

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

Fix an issue at the go client generated by an swagger config with basic auth support.
the UserName variable does not work in CamelCase

@wing328 wing328 added this to the v2.2.2 milestone Nov 24, 2016
@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Nov 28, 2016

@paulvollmer thanks for the PR.

cc @guohuang

@wing328 wing328 merged commit 77b92d7 into swagger-api:master Dec 12, 2016
@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Dec 12, 2016

@paulvollmer thanks for the PR. Moving forward, I would suggest you to create a new branch for the change as per git best practice.

(If your company is using Swagger Codegen, please consider adding your company name to this list)

@wing328 wing328 changed the title Fix go client auth UserName var issue [Go] Fix variable naming "UserName" Feb 20, 2017
davidgri pushed a commit to davidgri/swagger-codegen that referenced this pull request May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants