[PHP] fix PHPUnit invocation, add basic phpunit.xml.dist#3864
Merged
wing328 merged 2 commits intoswagger-api:masterfrom Sep 28, 2016
Merged
[PHP] fix PHPUnit invocation, add basic phpunit.xml.dist#3864wing328 merged 2 commits intoswagger-api:masterfrom
wing328 merged 2 commits intoswagger-api:masterfrom
Conversation
dkarlovi
changed the title
Contributor
arnested
reviewed
Sep 26, 2016
| stopOnFailure="false"> | ||
| <testsuites> | ||
| <testsuite> | ||
| <directory>SwaggerClient-php/test/Api</directory> |
Contributor
There was a problem hiding this comment.
Hmmm...
If I run vendor/bin/phpunit no tests are executed.
If I drop SwaggerClient-php/ from the paths in this file the tests run fine.
A change to phpunit.xml.mustache could be to prefix {{apiTestPath}} etc. with ../ -- but maybe you have a bette alternative.
Overall this looks like a good improvement!
We should probably adjust samples/client/petstore/php/SwaggerClient-php/pom.xml as well:
diff --git a/samples/client/petstore/php/SwaggerClient-php/pom.xml b/samples/client/petstore/php/SwaggerClient-php/pom.xml
index faaeba8..5a0007c 100644
--- a/samples/client/petstore/php/SwaggerClient-php/pom.xml
+++ b/samples/client/petstore/php/SwaggerClient-php/pom.xml
@@ -47,9 +47,6 @@
</goals>
<configuration>
<executable>vendor/bin/phpunit</executable>
- <arguments>
- <argument>test</argument>
- </arguments>
</configuration>
</execution>
</executions>
Contributor
Author
There was a problem hiding this comment.
Oh, I see the problem, I've tested it with my own config file which sets srcBasePath: . so getPackagePath() is not required (as phpunit.xml.dist gets created inside it, not beside it). I'll fix it, along with the file you suggested.
Thanks.
Contributor
Author
There was a problem hiding this comment.
@arnested seems alright now, I've tested it with all kinds of permutations, should work fine.
dkarlovi
force-pushed
the
fix/phpunit-setup
branch
from
dd8c11d to
8344d62
Compare
Contributor
|
Did a test with a new PHP SDK, which works fine as expected. |
acramatte
added a commit
to comerge/swagger-codegen
that referenced
this pull request
Oct 4, 2016
* upstream/master: (79 commits) add undertow Add a new cli command to output version information (2nd attempt) swagger-api#3892 (swagger-api#3899) fix python flask controller without tag (default_controller) [aspnet5] Fix basePath application to operations (swagger-api#3911) Bugfix/issue 3723 (swagger-api#3726) Cgardens nested object regex (swagger-api#3879) [Cpprest] Fixing issue swagger-api#3773 (swagger-api#3876) escape callback parameter for java(okhttp) and python fix warning in html generator [PHP] fix PHPUnit invocation, add basic phpunit.xml.dist (swagger-api#3864) [Java] Remove duplicated model description in Spring, JAX-RS models (swagger-api#3887) [PHP] Better PSR2 compatibility (swagger-api#3863) Mention security script in pull request template [Swift] Use thread safe manager dictionary Replace ^M with new line (\r) in mustache template (swagger-api#3865) [swfit] fix url param with base name [JaxRS]Show correct default value on CLI option description (swagger-api#3862) add title, description to HTML output (swagger-api#3860) fix trailing comma in go api client fix typescript-fetch base path by removing ending slash ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
This PR fixes the PHPUnit setup in PHP client. The new setup provides a basic phpunit.xml file which allows for more simple invocation.
Also,
.travisused a hardcoded path to test folder which is not necessarily valid with directory name config changes.To verify it works, just run: