Add a new cli command to output version information (2nd attempt) #3892#3899
Add a new cli command to output version information (2nd attempt) #3892#3899wing328 merged 3 commits intoswagger-api:masterfrom
Conversation
| <resources> | ||
| <resource> | ||
| <directory>src/main/resources</directory> | ||
| <filtering>true</filtering> |
There was a problem hiding this comment.
I fear there might have some side effects as we are filtering all the files under src/main/resources, not just the version.properties one – including all the templates.
To make sure that there are none, could you actually run all the petstore samples and see if there are any changes in the output?
There was a problem hiding this comment.
Unless I'm missing anything build-wise, I think this should not be a problem because the filtering is enabled just for the swagger-codegen-cli artifact and should not apply to the resources from swagger-codegen artifact (which is where all the templates are included as resources).
Running the samples should be a good practice anyway, so I'll try to find the time to do so, however.
There was a problem hiding this comment.
Ah, good point, I missed this.
|
@MiguelGL thanks for the PR, which has been merged into master. Test result looks good: |
* upstream/master: (79 commits) add undertow Add a new cli command to output version information (2nd attempt) swagger-api#3892 (swagger-api#3899) fix python flask controller without tag (default_controller) [aspnet5] Fix basePath application to operations (swagger-api#3911) Bugfix/issue 3723 (swagger-api#3726) Cgardens nested object regex (swagger-api#3879) [Cpprest] Fixing issue swagger-api#3773 (swagger-api#3876) escape callback parameter for java(okhttp) and python fix warning in html generator [PHP] fix PHPUnit invocation, add basic phpunit.xml.dist (swagger-api#3864) [Java] Remove duplicated model description in Spring, JAX-RS models (swagger-api#3887) [PHP] Better PSR2 compatibility (swagger-api#3863) Mention security script in pull request template [Swift] Use thread safe manager dictionary Replace ^M with new line (\r) in mustache template (swagger-api#3865) [swfit] fix url param with base name [JaxRS]Show correct default value on CLI option description (swagger-api#3862) add title, description to HTML output (swagger-api#3860) fix trailing comma in go api client fix typescript-fetch base path by removing ending slash ...
3 participants
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
(Second PR, after fixing issues with my account email references)
This is as per discussed in #3007. I am using maven resources filtering support to generate a resource file with the ${project.version} stamped on it.
Please note when running (from example from an IDE) from a non-maven env. this will lead to the
version be the literal
unsetstring.