Skip to content

[TypeScript Fetch] Fix typo {{classname}}FetchParamCreactor#4070

Closed
albertpastrana wants to merge 1 commit intoswagger-api:masterfrom
albertpastrana:fix-typo-fetch-param-creactor
Closed

[TypeScript Fetch] Fix typo {{classname}}FetchParamCreactor#4070
albertpastrana wants to merge 1 commit intoswagger-api:masterfrom
albertpastrana:fix-typo-fetch-param-creactor

Conversation

@albertpastrana
Copy link
Copy Markdown
Contributor

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

There was a typo, this is just about changing FetchParamCreactor to FetchParamCreator.

I've done it in the 2.3.0 branch as this is potentially a breaking change (people out there using the class XFetchParamCreactor will need to modify their code).

There was a typo, just changing `FetchParamCreactor` to `FetchParamCreator`
@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Oct 25, 2016

@albertpastrana thanks for the PR.

Please resubmit it for 2.3.0 branch instead as you've pointed out it's a breaking change.

Please also run ./bin/typescript-fetch-petstore-all.sh to update the samples so that the CI can test the change.

@wing328 wing328 added this to the v2.2.2 milestone Oct 25, 2016
@albertpastrana albertpastrana deleted the fix-typo-fetch-param-creactor branch October 26, 2016 07:29
@albertpastrana
Copy link
Copy Markdown
Contributor Author

Sorry, I had two branches and it looks like I've ended up raising the PR against the wrong branch :(
Will close that one and submit it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants