Skip to content

[TypeScript Fetch] Fixes typo in FetchParamCreactor#4075

Merged
wing328 merged 1 commit intoswagger-api:2.3.0from
albertpastrana:fix-typo-creactor
Oct 26, 2016
Merged

[TypeScript Fetch] Fixes typo in FetchParamCreactor#4075
wing328 merged 1 commit intoswagger-api:2.3.0from
albertpastrana:fix-typo-creactor

Conversation

@albertpastrana
Copy link
Copy Markdown
Contributor

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

There was a typo, this is just about changing FetchParamCreactor to FetchParamCreator.

I've done it in the 2.3.0 branch as this is potentially a breaking change (people out there using the class XFetchParamCreactor will need to modify their code).
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

This was raised incorrectly in #4070.

There was a typo, just changing `FetchParamCreactor` to `FetchParamCreator`
@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Oct 26, 2016

@albertpastrana the change looks good to me. Thanks for the contribution.

@wing328 wing328 merged commit 7fc17a2 into swagger-api:2.3.0 Oct 26, 2016
@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Oct 26, 2016

Upgrade Note

FetchParamCreactor methods (which contain a typo) have been renamed to FetchParamCreator. Please update your code accordingly.

@albertpastrana albertpastrana deleted the fix-typo-creactor branch October 26, 2016 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants