[JS] Add constructFromObject to Javascript enum generation.#4120
Merged
wing328 merged 2 commits intoswagger-api:masterfrom Nov 5, 2016
Merged
[JS] Add constructFromObject to Javascript enum generation.#4120wing328 merged 2 commits intoswagger-api:masterfrom
wing328 merged 2 commits intoswagger-api:masterfrom
Conversation
Generated code calls constructFromObject on enum types, but enum did not define the necessary function. Returns the value of the enum.
Contributor
|
@keysolutions please run |
Contributor
|
@keysolutions thanks for the PR, which has been merged into master. |
acramatte
added a commit
to comerge/swagger-codegen
that referenced
this pull request
Nov 9, 2016
* upstream/master: (42 commits) add vendor extension to handle void response in jaxrs-cxf better handling of */* Select application/json content-type in python generated client, if */* is in the list of content-types update mxf4j sample [ObjC] Fix deprecated JSONModel API usage (swagger-api#4133) [aspnet5] Fix broken template directory for deprecated lang (swagger-api#4142) Add constructFromObject to Javascript enum generation. (swagger-api#4120) [Obj-c] Generated code documentation fixes (swagger-api#4130) Added QAdept to companies list added clarification for swagger-api#4138 Default added sourceFolder to src/main/java Update pojo.mustache [feign] Use feign-form (swagger-api#4124) DART: Removed the 'justIgnoreThisFlag' flag (swagger-api#4116) fix[dart]: multi-word class names work properly now [ruby] Validate array correctly It never throws error with any values in array. Every element should be validated against the enum. remove glassfish dependencies and use MSF4J internal implementation for the simplicity and reduce dependencies updated to next development version Added isEmtyString check to avoid IndexOutOfBoundException Nancy fx work (swagger-api#4107) ...
wing328
changed the title
wing328
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated code calls constructFromObject on enum types, but enum did not define the necessary function. Returns the value of the enum.