Skip to content

[Java][Feign] Use OpenFeign, update Feign to v9.3.1, better handling of dates in parameters#4124

Merged
wing328 merged 2 commits intoswagger-api:masterfrom
cbornet:feign_form
Nov 4, 2016
Merged

[Java][Feign] Use OpenFeign, update Feign to v9.3.1, better handling of dates in parameters#4124
wing328 merged 2 commits intoswagger-api:masterfrom
cbornet:feign_form

Conversation

@cbornet
Copy link
Copy Markdown
Contributor

@cbornet cbornet commented Nov 3, 2016

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

  • Replace our current form encoder by OpenFeign's one
  • Upgrade Feign version to 9.3.1
  • Use a Param Expander to convert java.util.Date to RFC3339

Fix #4108

@wing328 wing328 merged commit 901a981 into swagger-api:master Nov 4, 2016
@wing328 wing328 added this to the v2.2.2 milestone Nov 4, 2016
@cbornet cbornet deleted the feign_form branch November 4, 2016 13:28
acramatte added a commit to comerge/swagger-codegen that referenced this pull request Nov 9, 2016
* upstream/master: (42 commits)
  add vendor extension to handle void response in jaxrs-cxf
  better handling of */*
  Select application/json content-type in python generated client, if */* is in the list of content-types
  update mxf4j sample
  [ObjC] Fix deprecated JSONModel API usage (swagger-api#4133)
  [aspnet5] Fix broken template directory for deprecated lang (swagger-api#4142)
  Add constructFromObject to Javascript enum generation. (swagger-api#4120)
  [Obj-c] Generated code documentation fixes (swagger-api#4130)
  Added QAdept to companies list
  added clarification for swagger-api#4138
  Default added sourceFolder to src/main/java
  Update pojo.mustache
  [feign] Use feign-form (swagger-api#4124)
  DART: Removed the 'justIgnoreThisFlag' flag (swagger-api#4116)
  fix[dart]: multi-word class names work properly now
  [ruby] Validate array correctly It never throws error with any values in array. Every element should be validated against the enum.
  remove glassfish dependencies and use MSF4J internal implementation for the simplicity and reduce dependencies
  updated to next development version
  Added isEmtyString check to avoid IndexOutOfBoundException
  Nancy fx work (swagger-api#4107)
  ...
@wing328 wing328 changed the title [feign] Use feign-form [Java][Feign] Use OpenFeign, update Feign to v9.3.1, better handling of dates in parameters Feb 20, 2017
davidgri pushed a commit to davidgri/swagger-codegen that referenced this pull request May 11, 2017
* [feign] Use feign-form

Fix swagger-api#4108

* [feign] Convert java.util.Date params to rfc3339 with an Expander
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants