[JAX-RS][Jersey2] Fix for incorrect JSON field name capitalization#4458
Merged
wing328 merged 3 commits intoswagger-api:masterfrom Jan 10, 2017
Merged
[JAX-RS][Jersey2] Fix for incorrect JSON field name capitalization#4458wing328 merged 3 commits intoswagger-api:masterfrom
wing328 merged 3 commits intoswagger-api:masterfrom
Conversation
Contributor
|
@y-higuchi thanks for the fix and the additional test cases to cover it moving forward. |
wing328
changed the title
This was referenced Mar 16, 2017
3 tasks
davidgri
pushed a commit
to davidgri/swagger-codegen
that referenced
this pull request
May 11, 2017
…agger-api#4458) * Fix for all capital field name * Cosmetic: remove trailing spaces * Adding ./bin/jaxrs-petstore-server.sh output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
JSON representation of model object, which had field with all capitals, resulted in same field content getting outputted twice in 2 different capitalization form.
This patch add
@JsonPropertyannotation to the template for getter to avoid them.Also added model object to
petstore-with-fake-endpoints-models-for-testing.yamland unit test
CapitalizationTest.javato high light the issue.I should've searched thoroughly before working on it,
but I've found #4066 which seems to be reporting same problem,
which proposes a fix in a different way.
Since this effective part of this patch is template only,
I'm using this version of template with swagger-codegen-maven-plugin 2.2.1,
specifying templateDirectory and additional-properties, jackson=true to configOptions.
So I thought it might be worth submitting PR anyways.