Update samples for java/jersey2-java6 (and fix artifact ID)#5118
Update samples for java/jersey2-java6 (and fix artifact ID)#5118wing328 merged 3 commits intoswagger-api:masterfrom
Conversation
ePaul
left a comment
ePaul
left a comment
There was a problem hiding this comment.
Pointing out where the changes come from.
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # |
| @@ -0,0 +1,15 @@ | |||
|
|
|||
| # Capitalization | |||
| @@ -0,0 +1,10 @@ | |||
|
|
|||
| # ClassModel | |||
|
|
||
| To test \"client\" model | ||
|
|
||
| To test \"client\" model |
There was a problem hiding this comment.
This duplicated line is here because the summary and description is the same. With 9051848 (I don't see a PR for this) the key was fixed from descriptions (which was ignored) to description.
| @@ -0,0 +1,14 @@ | |||
|
|
|||
| # OuterEnum | |||
|
|
||
| // create path and map variables | ||
| String localVarPath = "/fake".replaceAll("\\{format\\}","json"); | ||
| String localVarPath = "/fake"; |
| * Multiple status values can be provided with comma separated strings | ||
| * @param status Status values that need to be considered for filter (required) | ||
| * @return List<Pet> | ||
| * @return List<Pet> |
There was a problem hiding this comment.
#4616 changed {{{returnType}}} to {{returnType}} here.
| @JsonSubTypes({ | ||
| @JsonSubTypes.Type(value = Dog.class, name = "Dog"), | ||
| @JsonSubTypes.Type(value = Cat.class, name = "Cat"), | ||
| }) |
| * @return mapProperty | ||
| **/ | ||
| @ApiModelProperty(example = "null", value = "") | ||
| @ApiModelProperty(value = "") |
There was a problem hiding this comment.
It looks like previously we got a string "null" instead of a real null for the example, which confused the null-check.
I didn't figure out which commit/PR fixed this.
There was a problem hiding this comment.
@ePaul I remember Tony Tam filed a PR to fix it. If you need the number, I can dig it out for you.
| Name | Type | Description | Notes | ||
| ------------ | ------------- | ------------- | ------------- | ||
| **uuid** | **String** | | [optional] | ||
| **uuid** | [**UUID**](UUID.md) | | [optional] |
There was a problem hiding this comment.
@ePaul there's a discussion about updating isPrimitiveType to include UUID as well. IMO, isPrimitiveType should include UUID.
(the issue was caused by the change that maps uuid as UUID instead of String in Java)
ePaul
changed the title
This is the equivalent change to swagger-api#5095, for jersey2-java6.
ePaul
force-pushed
the
update-samples-jersey2-java6
branch
from
ad40ff3 to
232166f
Compare
|
@ePaul thanks for updating the sample. I'll update |
…api#5118) * Update samples for java/jersey2-java6. * Let the sample generation script set the right name for jersey2-java6. This is the equivalent change to swagger-api#5095, for jersey2-java6. * Update samples for Java/Jersey2-java6.
2 participants
PR checklist
./bin/to update Petstore sample so that CIs can verify the change.→ bin/java-petstore-jersey2-java6.sh
Description of the PR
This has no generator code changes, just updates some samples so later code changes see the actual effect on the samples. I also updated the sample generation script to use
-artifact-id swagger-petstore-jersey2-java6so the generation doesn't destroy the changed artifact name in the generated pom.xml. (There doesn't seem to be a windows script for this.)