Skip to content

[Jaxrs-spec] Update jaxrs-spec to interface/impl pattern #4509#4717

Closed
jfiala wants to merge 2 commits intoswagger-api:masterfrom
jfiala:jaxrs_spec_4509
Closed

[Jaxrs-spec] Update jaxrs-spec to interface/impl pattern #4509#4717
jfiala wants to merge 2 commits intoswagger-api:masterfrom
jfiala:jaxrs_spec_4509

Conversation

@jfiala
Copy link
Copy Markdown
Contributor

@jfiala jfiala commented Feb 5, 2017

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

I filed against master, please review & let me know if I should do against 2.3.0.
I'd prefer setting up a temporary language so we can have the change in 2.2.2.

Description of the PR

see #4509

@jfiala
Copy link
Copy Markdown
Contributor Author

jfiala commented Feb 5, 2017

@wing328 I filed against master for review, I'd like to have this in 2.2.2 - should I create a temporary language for this or do you want to stick with 2.3.0?

@jfiala jfiala changed the title Update jaxrs-spec to interface/impl pattern #4509 [Jaxrs-spec] Update jaxrs-spec to interface/impl pattern #4509 Feb 5, 2017
@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Feb 7, 2017

@jfiala from what I can tell it's a breaking change so I suggest we file it against 2.3.0 instead (we'll release 2.3.0 after the 2.2.2 release)

@wing328 wing328 added this to the v2.2.2 milestone Feb 7, 2017
@jfiala
Copy link
Copy Markdown
Contributor Author

jfiala commented Feb 7, 2017

@wing328 you're right, I can create a copy of the whole language so we can make it into 2.2.2 (as "jaxrs-spec-interface" or something like that) or we file it against 2.3.0, what do you prefer? I have a slightly preference for getting this into 2.2.2 if you agree (by copying).

@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Feb 7, 2017

@jfiala actually I want to freeze the current master and release 2.2.2. The community is very active (which is definitely a good thing) and we're seeing at least several new PRs (enhancements, bug fixes) every day so my take is to release 2.2.2 earlier and push those enhancements, bug fixes to the next release instead.

@jfiala
Copy link
Copy Markdown
Contributor Author

jfiala commented Feb 7, 2017

@wing328 OK, then lets schedule this for 2.3.

@jfiala
Copy link
Copy Markdown
Contributor Author

jfiala commented Feb 7, 2017

closed, will do again against 2.3.0.

@moshelav
Copy link
Copy Markdown

moshelav commented Jan 29, 2018

Based on CXF 3 and swagger 2.1.6 on Oracle 12.2.

I am experiencing jersey (2) validation errors as swagger file type generated ReST with @multipart Inputstream AND Attachment arguments. By manually removing the generated Attachment argument from the ReST Interface API, it seems work... so does the following suggestion entered:

Is there a way that swagger will not generate the additional Attachment argument in the ReST interface? maybe the mustache should not have Attachment at all, only the InputStream is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants