Skip to content

[Jaxrs-spec] Update jaxrs-spec to interface/impl pattern #4509#4744

Open
jfiala wants to merge 2 commits intoswagger-api:masterfrom
jfiala:2.3.0_jaxrs_spec_4509
Open

[Jaxrs-spec] Update jaxrs-spec to interface/impl pattern #4509#4744
jfiala wants to merge 2 commits intoswagger-api:masterfrom
jfiala:2.3.0_jaxrs_spec_4509

Conversation

@jfiala
Copy link
Copy Markdown
Contributor

@jfiala jfiala commented Feb 7, 2017

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

see #4509
This was originally filed against master of 2.2.2-SNAPSHOT with PR #4717, but then scheduled for release 2.3.0.

I split interface/implementation and cleaned up the implementation so it doesn't have annotations.
I also fixed the generatedAnnotation.mustache to contain the check for {{^hideGenerationTimestamp}}.
The samples were completely outdated (old package names etc.), I updated them to the current state.

Open issues (from master):

  • There are errors in the FakeApi.java/FakeApiServiceImpl.java due to joda and @patch, which I left as is, these have probably been fixed in the master.
  • CodegenResponse.java is missing the vendorExtensions, so I added a TODO marker at AbstractJavaJAXRSServerCodegen.java.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants