Skip to content

[Swift3] Use thread safe manager dictionary#5610

Merged
wing328 merged 1 commit intoswagger-api:2.3.0from
ButterflyNetwork:swift3-thread-safe-manager
May 17, 2017
Merged

[Swift3] Use thread safe manager dictionary#5610
wing328 merged 1 commit intoswagger-api:2.3.0from
ButterflyNetwork:swift3-thread-safe-manager

Conversation

@jgavris
Copy link
Copy Markdown
Contributor

@jgavris jgavris commented May 10, 2017

PR checklist

  • Read the contribution guidelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

Fixes crashes due to concurrent access of managerStore dictionary. Port of #3873 which was for the Swift 2 client generator.

Depends on #5609 to pass the unit tests for the Petstore example project.

@jgavris
Copy link
Copy Markdown
Contributor Author

jgavris commented May 10, 2017

@wing328 @jaz-ah @Edubits

@jgavris
Copy link
Copy Markdown
Contributor Author

jgavris commented May 10, 2017

cc @vineetshah

@jaz-ah
Copy link
Copy Markdown
Contributor

jaz-ah commented May 10, 2017

+1 @wing328

@jgavris jgavris force-pushed the swift3-thread-safe-manager branch from a11af6d to ab28ff3 Compare May 17, 2017 14:37
@wing328 wing328 merged commit 97a4bac into swagger-api:2.3.0 May 17, 2017
@wing328 wing328 added this to the v2.3.0 milestone May 17, 2017
@jgavris jgavris deleted the swift3-thread-safe-manager branch May 17, 2017 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants